feat(metadata) Customize Resource & operations#1055
Merged
NoResponseMate merged 3 commits intoSylius:1.14from Nov 5, 2025
Merged
feat(metadata) Customize Resource & operations#1055NoResponseMate merged 3 commits intoSylius:1.14from
NoResponseMate merged 3 commits intoSylius:1.14from
Conversation
5898f27 to
a6135b8
Compare
This was referenced Aug 27, 2025
f2a8714 to
39d41d1
Compare
diimpp
reviewed
Oct 28, 2025
| /** | ||
| * @internal | ||
| */ | ||
| final class OperationResourceMutatorCollection implements OperationMutatorCollectionInterface |
Member
There was a problem hiding this comment.
It's Operation Mutator, but Operation Resource Mutator Collection -- how name was derived?
If resource part is necessary, should it be
--- OperationResourceMutatorCollection
+++ ResourceOperationMutatorCollectionlike so?
Member
Author
There was a problem hiding this comment.
I think this was an issue during name refactoring at some point. We should rename them on APIP too.
Member
Author
There was a problem hiding this comment.
I've fixed these 2 class names.
src/Bundle/SyliusResourceBundle.php
Outdated
| $container->addCompilerPass(new FallbackToKernelDefaultLocalePass()); | ||
| $container->addCompilerPass(new DoctrineContainerRepositoryFactoryPass()); | ||
| $container->addCompilerPass(new DoctrineTargetEntitiesResolverPass(new TargetEntitiesResolver()), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1); | ||
| $container->addCompilerPass(new MutatorPass()); |
Member
There was a problem hiding this comment.
Mutator is not specific enough name when used outside of Sylius\Resource\Metadata dir.
For example,
Suggested change
| $container->addCompilerPass(new MutatorPass()); | |
| $container->addCompilerPass(new MetadataMutatorPass()); |
src/Component/src/Metadata/Mutator/OperationMutatorCollectionInterface.php
Outdated
Show resolved
Hide resolved
src/Component/src/Metadata/Mutator/ResourceMutatorCollectionInterface.php
Show resolved
Hide resolved
Comment on lines
+66
to
+69
| /** | ||
| * @var Operation $operation | ||
| * @var string $key | ||
| */ |
Member
There was a problem hiding this comment.
Is this part necessary? Doesn't Operations have any internal type hints to handle this?
src/Component/src/Metadata/Resource/Factory/MutatorResourceMetadataCollectionFactory.php
Show resolved
Hide resolved
diimpp
reviewed
Oct 28, 2025
| /** | ||
| * @internal | ||
| */ | ||
| final class ResourceResourceMutatorCollection implements ResourceMutatorCollectionInterface |
Member
There was a problem hiding this comment.
Naming scheme doesn't make sense to me, but I'm a bit of out the loop on metadata
Prometee
requested changes
Oct 28, 2025
src/Component/src/Metadata/Mutator/ResourceMutatorCollection.php
Outdated
Show resolved
Hide resolved
1c3c841 to
360a824
Compare
Prometee
approved these changes
Nov 3, 2025
loic425
commented
Nov 4, 2025
src/Component/src/Metadata/Mutator/OperationMutatorCollectionInterface.php
Show resolved
Hide resolved
diimpp
approved these changes
Nov 4, 2025
src/Component/src/Metadata/Mutator/OperationMutatorCollectionInterface.php
Outdated
Show resolved
Hide resolved
…nterface.php Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
diimpp
approved these changes
Nov 4, 2025
NoResponseMate
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the same feature as this APIP one.
We need this feature for this issue.