Skip to content

[Channel] Fix missing channel tab in web profiler#17828

Closed
SVillette wants to merge 1 commit intoSylius:1.14from
SVillette:fix-channel-collector-name
Closed

[Channel] Fix missing channel tab in web profiler#17828
SVillette wants to merge 1 commit intoSylius:1.14from
SVillette:fix-channel-collector-name

Conversation

@SVillette
Copy link
Copy Markdown
Contributor

@SVillette SVillette commented Apr 3, 2025 •
edited
Loading

Q A
Branch? 1.14
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets ~
License MIT

See https://github.com/Sylius/Sylius/blob/1.14/UPGRADE-1.14.md

@SVillette SVillette requested a review from a team as a code owner April 3, 2025 13:12
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@GSadee
Copy link
Copy Markdown
Member

GSadee commented Apr 4, 2025

Hi @SVillette, thank you for your contribution, but the current name is appropriate, as it indicates the current service id, not an alias.
Ref.: #17471

@GSadee GSadee closed this Apr 4, 2025
@SVillette
Copy link
Copy Markdown
Contributor Author

SVillette commented Apr 7, 2025

Hi @GSadee,
I see what you mean, but it is weird as the channel tab was hidden in a fresh project install.
This change fixed the issue.
Do you want me to create an issue ?

@SVillette
Copy link
Copy Markdown
Contributor Author

SVillette commented Apr 7, 2025

@GSadee Indeed, I see I targeted the wrong branch as data collector name match the id in 1.14 branch but not in 2.0.
Could you reopen the PR please ? Or should I create a new PR ?

@SVillette SVillette mentioned this pull request Apr 16, 2025
Merged
@SVillette SVillette deleted the fix-channel-collector-name branch April 16, 2025 14:28
Wojdylak added a commit that referenced this pull request Apr 17, 2025
@Wojdylak
[Channel] Fix missing channel tab in web profiler (#17882)
1b57bc5 
| Q               | A
|-----------------|-----
| Branch?         | 2.0 <!-- see the comment below -->
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file
-->
| Related tickets | Follow up of #17828 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.14 or 2.0 branch
 - Features and deprecations must be submitted against the 2.1 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

As mentioned in #17828, the debug bar doesn't display the channel tab.
This PR fixes this issue which is present since 2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SVillette @GSadee