Skip to content

Fix channel collector's name to match the tag's id#17471

Merged
TheMilek merged 1 commit intoSylius:1.14from
GSadee:fix-channel-collector-name
Nov 15, 2024
Merged

Fix channel collector's name to match the tag's id#17471
TheMilek merged 1 commit intoSylius:1.14from
GSadee:fix-channel-collector-name

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented Nov 15, 2024

Q A
Branch? 1.14
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #17468
License MIT

According to the Symfony docs, the value returned by the getName() method must match the id defined in the data_collector tag.

@GSadee GSadee added DX Issues and PRs aimed at improving Developer eXperience. Bug Confirmed bugs or bugfixes. labels Nov 15, 2024
@GSadee GSadee requested review from a team as code owners November 15, 2024 10:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 15, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek merged commit 5c22699 into Sylius:1.14 Nov 15, 2024
@TheMilek
Copy link
Copy Markdown
Member

Thank you, @GSadee!

@GSadee GSadee deleted the fix-channel-collector-name branch November 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants