[CI] Fix panther behats by mpysiak · Pull Request #17771 · Sylius/Sylius

mpysiak · 2025-03-25T10:05:15Z

Q	A
Branch?	2.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	failing CI
License	MIT

coderabbitai · 2025-03-25T10:05:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-25T10:40:26Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

Wojdylak · 2025-03-25T13:36:07Z

src/Sylius/Behat/Page/Shop/Page.php

 use Behat\Mink\Element\NodeElement;
 use Behat\Mink\Exception\ElementNotFoundException;
 use Sylius\Behat\Page\SymfonyPage;
+use Sylius\Behat\Service\DriverHelper;


Suggested change

use Sylius\Behat\Service\DriverHelper;

Wojdylak · 2025-03-25T13:37:04Z

src/Sylius/Behat/Page/Shop/Checkout/SelectPaymentPage.php

    public function selectPaymentMethod(string $paymentMethod): void
    {
        if (DriverHelper::isJavascript($this->getDriver())) {
+            $this->getSession()->wait(100, "document.body !== null");


Suggested change

$this->getSession()->wait(100, "document.body !== null");

DriverHelper::waitForPageToLoad($this->getSession());

Wojdylak · 2025-03-25T13:37:16Z

src/Sylius/Behat/Page/Shop/Checkout/SelectShippingPage.php

    public function selectShippingMethod(string $shippingMethod): void
    {
        if (DriverHelper::isJavascript($this->getDriver())) {
+            $this->getSession()->wait(100, "document.body !== null");


Suggested change

$this->getSession()->wait(100, "document.body !== null");

DriverHelper::waitForPageToLoad($this->getSession());

Wojdylak · 2025-03-25T13:37:45Z

src/Sylius/Behat/Element/Shop/CartWidgetElement.php

 namespace Sylius\Behat\Element\Shop;

 use FriendsOfBehat\PageObjectExtension\Element\Element;
+use Sylius\Behat\Service\DriverHelper;


Suggested change

use Sylius\Behat\Service\DriverHelper;

GSadee · 2025-03-25T15:17:31Z

src/Sylius/Behat/Service/DriverHelper.php

    }

-    public static function waitForPageReload(Session $session): void
+    public static function waitForPageToLoad(Session $session): void


As it was introduced in 1.14, we should adjust the name also there

…orPageToLoad (#17773) | Q | A |-----------------|----- | Branch? | 1.14 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #17764 and #17771 | License | MIT

| Q | A |-----------------|----- | Branch? | 2.0 | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #17771 | License | MIT

probot-autolabeler bot added Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. labels Mar 25, 2025

mpysiak changed the base branch from 2.1 to 2.0 March 25, 2025 10:05

mpysiak changed the title ~~Syl 4531 fix panther behats~~ [CI] Fix panther behats Mar 25, 2025

[CI] Fix panther behats

04a222b

mpysiak force-pushed the SYL-4531-fix-panther-behats branch from 9d70d63 to 04a222b Compare March 25, 2025 11:33

probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Mar 25, 2025

mpysiak removed Documentation Documentation related issues and PRs - requests, fixes, proposals. Shop ShopBundle related issues and PRs. labels Mar 25, 2025

Change failing scenario to chrome

004fd82

probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Mar 25, 2025

mpysiak marked this pull request as ready for review March 25, 2025 12:12

mpysiak requested review from a team as code owners March 25, 2025 12:12

Rafikooo approved these changes Mar 25, 2025

View reviewed changes

Wojdylak reviewed Mar 25, 2025

View reviewed changes

GSadee approved these changes Mar 25, 2025

View reviewed changes

GSadee merged commit 2187232 into Sylius:2.0 Mar 25, 2025
27 checks passed

GSadee mentioned this pull request Mar 25, 2025

[Behat] Rename DriverHelper::waitForPageReload to DriverHelper::waitForPageToLoad #17773

Merged

mpysiak mentioned this pull request Mar 26, 2025

[Behat] Fix missing method usage #17775

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CI] Fix panther behats#17771

[CI] Fix panther behats#17771
GSadee merged 2 commits intoSylius:2.0from
mpysiak:SYL-4531-fix-panther-behats

mpysiak commented Mar 25, 2025

Uh oh!

coderabbitai bot commented Mar 25, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 25, 2025 •

edited

Loading

Uh oh!

Wojdylak Mar 25, 2025

Uh oh!

Wojdylak Mar 25, 2025

Uh oh!

Wojdylak Mar 25, 2025

Uh oh!

Wojdylak Mar 25, 2025

Uh oh!

GSadee Mar 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	$this->getSession()->wait(100, "document.body !== null");
	DriverHelper::waitForPageToLoad($this->getSession());

Uh oh!

Conversation

mpysiak commented Mar 25, 2025

Uh oh!

coderabbitai bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Wojdylak Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Wojdylak Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Wojdylak Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Wojdylak Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

GSadee Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Mar 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 25, 2025 •

edited

Loading