[Behat] Add wait for page reload#17764
Merged
mpysiak merged 1 commit intoSylius:1.14from Mar 24, 2025
Merged
Conversation
Member
Wojdylak
commented
Mar 20, 2025
| Q | A |
|---|---|
| Branch? | 1.14 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | n/a |
| License | MIT |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
7179ad3 to
b6bd041
Compare
GSadee
approved these changes
Mar 24, 2025
Comment on lines
+24
to
+25
| DriverHelper::waitForPageReload($this->getSession()); | ||
| return parent::getElement($name, $parameters); |
Member
There was a problem hiding this comment.
Suggested change
| DriverHelper::waitForPageReload($this->getSession()); | |
| return parent::getElement($name, $parameters); | |
| DriverHelper::waitForPageReload($this->getSession()); | |
| return parent::getElement($name, $parameters); |
Rafikooo
approved these changes
Mar 24, 2025
mpysiak
approved these changes
Mar 24, 2025
|
|
||
| use FriendsOfBehat\PageObjectExtension\Page\SymfonyPageInterface as BaseSymfonyPageInterface; | ||
|
|
||
| interface SymfonyPageInterface extends BaseSymfonyPageInterface |
Contributor
There was a problem hiding this comment.
Do we need this interface?
mpysiak
added a commit
that referenced
this pull request
Mar 26, 2025
…orPageToLoad (#17773) | Q | A |-----------------|----- | Branch? | 1.14 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | after #17764 and #17771 | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.