Fix action templates with url option#259
Merged
loic425 merged 1 commit intoSylius:mainfrom May 6, 2025
Merged
Conversation
81e4a07 to
bf62e63
Compare
loic425
commented
May 5, 2025
| {% if options.link.url is defined %} | ||
| {% set path = options.link.url %} | ||
| {% else %} | ||
| {% set default_route = options.link.route|default(grid.requestConfiguration is defined ? grid.requestConfiguration.getRouteName('delete') : null) %} |
Member
Author
There was a problem hiding this comment.
grid.requestConfiguration is defined only when using the GridViewFactory from the Resource bundle (using a ResourceGridView). It's not working with the GridViewFactory from the Grid bundle one (using a GridView).
We'll need that fix for the future Grid as Live component.
e57bd32 to
4c3a187
Compare
stlgaits
approved these changes
May 5, 2025
4c3a187 to
9a8f57a
Compare
GSadee
added a commit
to Sylius/Sylius
that referenced
this pull request
May 6, 2025
| Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | mentioned in Sylius/Stack#259 | License | MIT More details on related ticket. <!-- - Bug fixes must be submitted against the 1.14 or 2.0 branch - Features and deprecations must be submitted against the 2.1 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.