Skip to content

Fix action templates for url option#17926

Merged
GSadee merged 1 commit intoSylius:2.0from
loic425:fix/action-templates
May 6, 2025
Merged

Fix action templates for url option#17926
GSadee merged 1 commit intoSylius:2.0from
loic425:fix/action-templates

Conversation

@loic425
Copy link
Copy Markdown
Member

@loic425 loic425 commented May 5, 2025 •
edited
Loading

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in Sylius/Stack#259
License MIT

More details on related ticket.

@loic425 loic425 requested review from a team as code owners May 5, 2025 09:43
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 5, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 5, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@loic425 loic425 added the Bug Confirmed bugs or bugfixes. label May 5, 2025
@loic425 loic425 force-pushed the fix/action-templates branch from 733d1e5 to 77c7ae5 Compare May 5, 2025 11:46
diimpp
diimpp previously approved these changes May 5, 2025
View reviewed changes
src/Sylius/Bundle/AdminBundle/templates/shared/grid/action/delete.html.twig
{% set id = options.link.parameters['id']|default(data.id) %}

{% set path = options.link.url|default(path(options.link.route|default(grid.requestConfiguration.getRouteName('delete')), options.link.parameters|default({'id': id}))) %}
{% if options.link.url is defined %}
Copy link
Copy Markdown
Member

@diimpp diimpp May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing out just in case, since we have disabled state now,

{% if options.link.url is defined %}

will crash if options or options.link are undefined.

Personally, I would rather not support this case and receive the error as is if options are configured badly (If it's even possible with options validation in grid configuration).

Copy link
Copy Markdown
Member Author

@loic425 loic425 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it will crash? I'm not sure at all.

Copy link
Copy Markdown
Member

@GSadee GSadee May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check that to be sure? 🤔

Copy link
Copy Markdown
Member

@diimpp diimpp May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to docs -- yes,

https://twig.symfony.com/doc/3.x/tests/defined.html
image

but in playground looks alright

https://twig.symfony.com/play?data=eyJ0ZW1wbGF0ZXMiOltbImluZGV4LnR3aWciLCJ7JSBzZXQgb3B0aW9ucyA9IHtcImxpbmtcIjoge1widXJsXCI6ICdleGFtcGxlLmNvbSd9fSAlfVxuXG57JSBpZiBvcHRpb25zLm5vdF9leGlzdHMudXJsIGlzIGRlZmluZWQgJX1cbnt7IG9wdGlvbnMubm90X2V4aXN0cy51cmwgfX1cbnslIGVuZGlmICAlfSJdXSwiY29udGV4dCI6eyJuYW1lIjoiV29ybGQifSwidmVyc2lvbiI6IjMuMTkuMCIsIm9wdGlvbnMiOnsic3RyaWN0X3ZhcmlhYmxlcyI6dHJ1ZSwiY2hhcnNldCI6IlVURi04IiwiYXV0b2VzY2FwZSI6IiJ9fQ%3D%3D

@loic425 loic425 force-pushed the fix/action-templates branch from 77c7ae5 to e10dc62 Compare May 5, 2025 12:54
@GSadee GSadee merged commit 617fb7b into Sylius:2.0 May 6, 2025
27 checks passed
@GSadee
Copy link
Copy Markdown
Member

GSadee commented May 6, 2025

Thank you Loic! 🎉

@loic425 loic425 deleted the fix/action-templates branch May 6, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diimpp diimpp diimpp approved these changes

@GSadee GSadee GSadee approved these changes

Assignees

No one assigned

Labels

Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loic425 @GSadee @diimpp