Support Xcode 8 and Swift 2.3 by ikesyo · Pull Request #179 · SwiftGen/SwiftGen

ikesyo · 2016-09-27T04:38:44Z

Supersedes #171, #176 and #178. This preserves Xcode 7.3 support.

CocoaPods 1.1.0.rc.2 is required.

…compatible with Swift 2.3 - Commander 0.5.0 is for Swift 3 - PathKit 0.7.0 is for Swift 3 - Stencil 0.6.0 is for Swift 3

AliSoftware · 2016-09-27T07:04:20Z

Thanks for the PR.

Don't forget to add s CHANGELOG entry; it would be nice to mention the original author of the related PR that made the effort on the 2.3 port as well in that entry

ikesyo · 2016-09-27T13:02:58Z

Updated!

dzenbot · 2016-10-01T23:04:26Z

Yay I made it to the changelog! 💪 Thanks!

dzenbot

Looks good to me!

AndrewSB · 2016-10-04T02:06:04Z

hey @ikesyo, I tried to compile this on Xcode 8, I saw some issues with dependencies - is this PR supposed to get swiftgen all the way up to Xcode 8 support, or should updating the dependencies be another pull request?

ikesyo · 2016-10-04T02:18:38Z

@AndrewSB This should be fine on Xcode 8 with Swift 2.3: https://travis-ci.org/AliSoftware/SwiftGen/jobs/163091175. I'm not sure what the issues you are facing are.

dzenbot · 2016-10-04T02:28:33Z

Xcode 8 sometimes pops up with its migration tool if it's set to Swift 2.3, wanting to update to Swift 3.0. Maybe that's what you mean @AndrewSB ?

AndrewSB · 2016-10-04T03:12:55Z

@dzenbot I do see that popup, but I'm having errors past that. Something related to if let syntax in GenumKit, and missing SWIFT_VERSION flags in the cocoapods frameworks:

AndrewSB · 2016-10-04T03:16:01Z

Let me submit a PR with the changes that I needed to get swiftgen to build, so we can talk about if they're needed or not 👍

dzenbot · 2016-10-04T03:18:45Z

Interesting. For the frameworks needing the SWIFT_VERSION flag, I realized that Cocoapods isn't helping with that sometimes, so I fixed it this way on my project:
https://github.com/dzenbot/Iconic/blob/bc1ced02c4b2294040379ba908dffcec2e825396/Samples/Podfile#L26-#L32

AndrewSB · 2016-10-04T03:28:22Z

(submitted #179)

Yeah! It is super weird. Strange that someone hasn't contributed that change to Cocoapods 🤔

dzenbot · 2016-10-04T03:40:46Z

You mean #182 ?

AndrewSB · 2016-10-04T03:44:35Z

I do, thanks @dzenbot #selfretaincycle 😛

ikesyo · 2016-10-04T04:09:06Z

@AndrewSB You need CocoaPods 1.1.0.rc.2 to use Xcode 8. This pull request ran pod update with the version.

ikesyo · 2016-10-04T04:14:16Z

Interesting. For the frameworks needing the SWIFT_VERSION flag, I realized that Cocoapods isn't helping with that sometimes, so I fixed it this way on my project

@dzenbot CocoaPods 1.1.0 (currently rc.2) now handles the setting correctly.

AndrewSB · 2016-10-04T04:15:28Z

ahh, I see! I'll update to their release candidate then. Thank you for your work @ikesyo 😃

dzenbot · 2016-10-04T04:15:40Z

Good to know @ikesyo!

AndrewSB · 2016-10-04T18:08:49Z

Apologies on dragging this out, but I'm still having issues building this branch:

== Building Binary ==

set -o pipefail && xcrun -sdk macosx swiftc -O -o build/Release/swiftgen -F build/Release/PathKit -F build/Release/Stencil -F build/Release/Commander -F build/Release/GenumKit/ -framework PathKit -framework Stencil -framework Commander -framework GenumKit swiftgen-cli/*.swift | xcpretty -c
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected ':' following argumant label and parameter name
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected type
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected ',' separator
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
                                                                     ,
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected type
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected ',' separator
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
                                                                     ,
swiftgen-cli/ArgumentsUtils.swift:7:8: error: module compiled with Swift 2.3 cannot be imported in Swift 3.0: /Users/asb/Developer/SwiftGen/build/Release/Commander/Commander.framework/Modules/Commander.swiftmodule/x86_64.swiftmodule
import Commander
       ^
rake aborted!
Command failed with status (1): [set -o pipefail && xcrun -sdk macosx swift...]
/Users/asb/Developer/SwiftGen/Rakefile:24:in `xcpretty'
/Users/asb/Developer/SwiftGen/Rakefile:64:in `block in <top (required)>'
Tasks: TOP => install => install:light => build
(See full trace by running task with --trace)

Everything compiles, but the Rakefile fails after that, whilst building the swiftgen binary. Any idea what that could be?

kgrigsby59 · 2016-10-04T18:50:17Z

@AndrewSB You could run it as TOOLCHAINS=com.apple.dt.toolchain.Swift_2_3 rake install but a better solution would be to specify a toolchain in the xcrun command in the rakefile.

AndrewSB · 2016-10-04T19:16:37Z

that was perfect, thanks @kgrigsby59

On Tue, Oct 4, 2016 at 11:51 AM kgrigsby59 notifications@github.com wrote:

@AndrewSB https://github.com/AndrewSB You could run it as TOOLCHAINS=com.apple.dt.toolchain.Swift_2_3
rake install but a better solution would be to specify a toolchain in the
xcrun command in the rakefile.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#179 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADo1dNjlRqTR3arq9UNxMnJ_oH2oqFzBks5qwp_rgaJpZM4KHP-o
.

AndrewSB · 2016-10-29T20:35:17Z

@AliSoftware this looks good to go, can it be merged in?

AliSoftware · 2016-10-29T20:41:44Z

👍
Le sam. 29 oct. 2016 à 22:35, Andrew Breckenridge notifications@github.com
a écrit :

@AliSoftware https://github.com/AliSoftware this looks good to go, can
it be merged in?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#179 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANMGWBBKpJLO6woHi3CNuJPeXOObxmrks5q464GgaJpZM4KHP-o
.

AliSoftware · 2016-10-29T22:04:53Z

The only thing that prevents me to merge that is having some time to do an official release (I keep this PR open to remind me of doing a homebrew release once I've got enough time). That shouldn't take that long but I've been traveling lately and didn't use my Mac much so will need some time off to catch up on all those pending PRs on my various OSS work soon, sorry for the delay!

plivesey · 2016-11-04T20:50:50Z

@ikesyo I'm not sure if it's something to do with my personal machine, but rake install doesn't seem to work for me on this branch:

== Building Binary ==

xcrun -sdk macosx swiftc -O -o build/Release/swiftgen -F build/Release/PathKit -F build/Release/Stencil -F build/Release/Commander -F build/Release/GenumKit/ -framework PathKit -framework Stencil -framework Commander -framework GenumKit swiftgen-cli/*.swift
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected ':' following argumant label and parameter name
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected type
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected ',' separator
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
                                                                     ,
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected type
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
swiftgen-cli/ArgumentsUtils.swift:12:71: error: expected ',' separator
func checkPath(type: String, assertion: Path -> Bool) -> (Path throws -> Path) {
                                                                      ^
                                                                     ,
swiftgen-cli/ArgumentsUtils.swift:7:8: error: module compiled with Swift 2.3 cannot be imported in Swift 3.0.1: /Users/plivesey/Repo/temp/SwiftGen/build/Release/Commander/Commander.framework/Modules/Commander.swiftmodule/x86_64.swiftmodule
import Commander
       ^
rake aborted!
Command failed with status (1): [xcrun -sdk macosx swiftc -O -o build/Relea...]
/Users/plivesey/Repo/temp/SwiftGen/Rakefile:26:in `xcpretty'
/Users/plivesey/Repo/temp/SwiftGen/Rakefile:64:in `block in <top (required)>'
Tasks: TOP => install => install:light => build
(See full trace by running task with --trace)

It seems like swiftc is running with Swift 3, but everything is compile with Swift 2.3. My guess is we need to add a flag to:

xcpretty %Q(xcrun -sdk macosx swiftc -O -o #{BUILD_DIR}/#{BIN_NAME} #{search_paths}/ #{frameworks} swiftgen-cli/*.swift)

which includes the swift version. I can't work out how to do this though...

Thoughts? Or is this working for you?

plivesey · 2016-11-04T21:02:28Z

Looks like it gets further here if you change to:

xcpretty %Q(TOOLCHAINS=com.apple.dt.toolchain.Swift_2_3 xcrun -sdk macosx swiftc -O -o #{BUILD_DIR}/#{BIN_NAME} #{search_paths}/ #{frameworks} swiftgen-cli/*.swift)

But then fails later when it does other toolchain stuff...which I don't understand :/

ikesyo · 2016-11-05T00:21:28Z

@plivesey Did you see #179 (comment)? Specifying a toolchain explicitly in Rakefile makes it difficult to support both Xcode 7.3 and Xcode 8.

That would be fine if dropping Xcode 7.3 support is okay.

dzenbot · 2016-11-06T16:45:50Z

🎉 💯

AliSoftware · 2016-11-06T17:23:30Z

Finally, I've found some time to merge this!

@plivesey @ikesyo @AndrewSB I've fixed the Rakefile in aa6ed1d so that now it:

auto-selects the latest Xcode 8 found in your machine… even if it's not your default Xcode (using DEVELOPER_DIR=… instead of forcing you to xcode-select -s)
raises if no Xcode 8 is found on your machine at all
forces TOOLCHAINS=com.apple.dt.toolchain.Swift_2_3 too

So now SwiftGen is officially Swift 2.3 (and thus only supporting Xcode 8)! 🎉

Next step: Swift 3.0 conversion… but that's for another day!

zmwangx · 2016-11-06T17:28:01Z

@AliSoftware Would you consider putting out a patch release for Homebrew? Thanks.

AliSoftware · 2016-11-06T17:28:48Z

@zmwangx That's the plan 👍

zmwangx · 2016-11-06T17:29:00Z

Cool, thanks.

AndrewSB · 2016-11-06T18:58:53Z

🎉🎉🎉 thanks @AliSoftware!

AliSoftware · 2016-11-06T21:46:36Z

3.0.1 should already be available thru CocoaPods.
Pull Request for the Homebrew release has been open, waiting for the Homebrew crew to merge.

plivesey · 2016-11-07T17:20:40Z

Thanks @AliSoftware and @ikesyo :). I couldn't work this all out on my own, but working after rebasing. 🎉

ikesyo added 5 commits September 27, 2016 13:24

Convert to Swift 2.3

dfca8ca

Update to recommended settings

2284061

Run pod install with CocoaPods 1.1.0.rc.2

0460226

Update .travis.yml for Xcode 8 and CocoaPods 1.1.0.rc.2

8ff45b0

Update Rakefile for Xcode 8 requirement

b53b5ee

ikesyo changed the title ~~Support Xcode 8 and Swift 2.3~~ [WIP] Support Xcode 8 and Swift 2.3 Sep 27, 2016

Pin dependencies not to accidentaly update to versions those are not …

9a48940

…compatible with Swift 2.3 - Commander 0.5.0 is for Swift 3 - PathKit 0.7.0 is for Swift 3 - Stencil 0.6.0 is for Swift 3

ikesyo changed the title ~~[WIP] Support Xcode 8 and Swift 2.3~~ Support Xcode 8 and Swift 2.3 Sep 27, 2016

ikesyo added type: enhancement type: internal labels Sep 27, 2016

This was referenced Sep 27, 2016

Feature/swift 2.3 #171

Closed

Updates SwiftGen to Swift 2.3 #176

Closed

ikesyo added 2 commits September 27, 2016 21:59

Preserve Xcode 7.3 support

6542803

Update CHANGELOG

99db473

dzenbot approved these changes Oct 2, 2016

View reviewed changes

ikesyo mentioned this pull request Oct 4, 2016

explicitly set pods to use legacy swift language version (i.e. 2.3) #182

Closed

AndrewSB approved these changes Oct 17, 2016

View reviewed changes

AliSoftware merged commit 2393e98 into master Nov 6, 2016

AliSoftware deleted the xcode8-swift2.3 branch November 6, 2016 17:18

This was referenced Nov 6, 2016

increment required xcode_verison to 8.x #178

Closed

Convert project to Swift 3 and app bundle #169

Closed

Add "import" option, which can be used to add (multiple) import statements #175

Merged

This was referenced Nov 6, 2016

Install by Homebrew does not work #177

Closed

XCode 8 HomeBrew install errror #180

Closed

Conversation

ikesyo commented Sep 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AliSoftware commented Sep 27, 2016

Uh oh!

ikesyo commented Sep 27, 2016

Uh oh!

dzenbot commented Oct 1, 2016

Uh oh!

dzenbot left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewSB commented Oct 4, 2016

Uh oh!

ikesyo commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenbot commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewSB commented Oct 4, 2016

Uh oh!

AndrewSB commented Oct 4, 2016

Uh oh!

dzenbot commented Oct 4, 2016

Uh oh!

AndrewSB commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenbot commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewSB commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikesyo commented Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikesyo commented Oct 4, 2016

Uh oh!

AndrewSB commented Oct 4, 2016

Uh oh!

dzenbot commented Oct 4, 2016

Uh oh!

AndrewSB commented Oct 4, 2016

Uh oh!

kgrigsby59 commented Oct 4, 2016

Uh oh!

AndrewSB commented Oct 4, 2016

Uh oh!

AndrewSB commented Oct 29, 2016

Uh oh!

AliSoftware commented Oct 29, 2016

Uh oh!

AliSoftware commented Oct 29, 2016

Uh oh!

plivesey commented Nov 4, 2016

Uh oh!

plivesey commented Nov 4, 2016

Uh oh!

ikesyo commented Nov 5, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenbot commented Nov 6, 2016

Uh oh!

AliSoftware commented Nov 6, 2016

Uh oh!

zmwangx commented Nov 6, 2016

Uh oh!

AliSoftware commented Nov 6, 2016

Uh oh!

zmwangx commented Nov 6, 2016

Uh oh!

AndrewSB commented Nov 6, 2016

Uh oh!

AliSoftware commented Nov 6, 2016

Uh oh!

plivesey commented Nov 7, 2016

Uh oh!

ikesyo commented Sep 27, 2016 •

edited

Loading

ikesyo commented Oct 4, 2016 •

edited

Loading

dzenbot commented Oct 4, 2016 •

edited

Loading

AndrewSB commented Oct 4, 2016 •

edited

Loading

dzenbot commented Oct 4, 2016 •

edited

Loading

AndrewSB commented Oct 4, 2016 •

edited

Loading

ikesyo commented Oct 4, 2016 •

edited

Loading

ikesyo commented Nov 5, 2016 •

edited

Loading