Feature/swift 2.3#171
Closed
vknabel wants to merge 2 commits intoSwiftGen:masterfrom
vknabel:feature/swift-2.3
Closed
Feature/swift 2.3#171vknabel wants to merge 2 commits intoSwiftGen:masterfrom vknabel:feature/swift-2.3
vknabel wants to merge 2 commits intoSwiftGen:masterfrom
vknabel:feature/swift-2.3
Conversation
Collaborator
|
Seems cool 👌 will check that more thoroughly a bit later in the week when I've time to actually test the resulting project with the templates (don't see a reason why they would be affected) |
This was referenced Sep 27, 2016
Collaborator
|
Superseded by #179. Thanks for the pull request though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates SwiftGen to Swift 2.3 and would temporarily fixes #169 particularly.
A migration to Swift 3.0 would be much heavier and would take more time.
Currently, one can compile
swiftgen-cliand all unit tests pass.But I haven't checked the stencil templates yet.