Remove notfinished variables from ComputeJacobianTerms, and other style improvements#1273
Merged
Remove notfinished variables from ComputeJacobianTerms, and other style improvements#1273
notfinished variables from ComputeJacobianTerms, and other style improvements#1273Conversation
These typedefs are just needed for the internal implementation of `ComputeJacobianTerms::Compute()`, so they do not need to be part of the interface.
Removed this obviously redundant typedef from `ComputeJacobianTerms`. Also removed the unused `ScaledCostFunctionPointer` alias.
This typedef is just needed for the internal implementation of `ComputeJacobianTerms::Compute()`, so it does not need to be part of the interface.
The indirection via aliases (`FixedImageType = TFixedImage`, `TransformType = TTransform`) does not seem very useful.
2a17eac to
eef435d
Compare
The typedefs `FixedImageType` and `TransformType` are never used anymore. Internally, `ComputeJacobianTerms` directly uses its template parameters, `TFixedImage` and `TTransform`. `ComputeJacobianTerms` is only being used by `elx::AdaptiveStochasticGradientDescent::AutomaticParameterEstimationOriginal()` anyway.
eef435d to
f2f1ca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.