Conversation
Following C++ Core Guidelines, May 11, 2024: "Avoid `protected` data", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-protected
The prefix `this->` is not necessary when a class or template just accesses its own private data. Follow-up to commit 7618fa3
Clarified where those data member are from, when AdvancedBSplineDeformableTransform accesses a data member of a base class.
It appears unnecessary to use `std::vector` for those two AdvancedBSplineDeformableTransform data members, as those data members do not need to be resized.
Removed the setter and getters of `m_WeightsFunction`. (The comment asking "Why??" already suggested that they were unnecessary. This comment was there already with commit 3b50076, 27 October 2008.)
It appears unnecessary to reset the data of the Superclass, in the default-constructor of AdvancedBSplineDeformableTransform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using C-style arrays instead of
std::vectormight improve the run-time performance ofAdvancedBSplineDeformableTransform.Also made m_WeightsFunction const, and did clean-up the default-constructor of AdvancedBSplineDeformableTransform.