Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12587 +/- ##
=========================================
Coverage 21.66% 21.66%
Complexity 9637 9637
=========================================
Files 268 268
Lines 36222 36222
Branches 487 487
=========================================
Hits 7847 7847
Misses 27892 27892
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
IDzyre
approved these changes
Mar 16, 2026
Rkoester47
approved these changes
Mar 16, 2026
SkyBlue43
pushed a commit
to SkyBlue43/Submitty
that referenced
this pull request
Mar 19, 2026
### Why is this Change Important & Necessary? Submitty#12586 resolved Submitty#12580, allowing students to once again create teams on VCS gradeables, but not in "the PHP way". Because of this, `PHP Lint` was failing due to the way I used a ternary operator. ### What is the New Behavior? Instead of a ternary operator to guarantee we don't call `getId()` on `NULL`, we now just use the nullsafe operator, which "short-circuits the retrieval if the value is null, without causing any errors." ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Create a VCS team gradeable 2. Create and Leave a team 3. No errors ### Automated Testing & Documentation N/A ### Other information Co-authored-by: Cameron Peterson <46759635+IDzyre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
#12586 resolved #12580, allowing students to once again create teams on VCS gradeables, but not in "the PHP way". Because of this,
PHP Lintwas failing due to the way I used a ternary operator.What is the New Behavior?
Instead of a ternary operator to guarantee we don't call
getId()onNULL, we now just use the nullsafe operator, which "short-circuits the retrieval if the value is null, without causing any errors."What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
N/A
Other information