[Feature:InstructorUI] Adjust Archived Courses Home Page View#12154
Merged
[Feature:InstructorUI] Adjust Archived Courses Home Page View#12154
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12154 +/- ##
=========================================
Coverage 21.71% 21.71%
Complexity 9601 9601
=========================================
Files 268 268
Lines 36038 36038
Branches 475 475
=========================================
Hits 7827 7827
Misses 27740 27740
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…se-list-view-archived
Rkoester47
approved these changes
Oct 24, 2025
Contributor
Rkoester47
left a comment
There was a problem hiding this comment.
I was able to successfully hide and un-hide the list of archived courses using the feature introduced by this PR. The changes seem to be working as intended. The button looks good in both light and dark themes. I can easily see how this would help reduce clutter when the archived courses pile up.
JManion32
requested changes
Oct 29, 2025
Contributor
JManion32
left a comment
There was a problem hiding this comment.
Overall, the functionality looks good. I just left some small comments regarding best practices.
JManion32
approved these changes
Oct 31, 2025
Contributor
JManion32
left a comment
There was a problem hiding this comment.
Code looks good and feature enhances the quality of life for users with many archived courses. Looks like you just need to resolve that 1 failing Cypress test and this is all set for merge.
bmcutler
pushed a commit
that referenced
this pull request
Nov 19, 2025
### Why is this Change Important & Necessary? CI is failing due to `registration.spec.js`. This was caused in #12154 from nesting a `<button>` inside of an `<h1>` element, so when Cypress went to assert that the header said "My Courses", it returned "My Courses " instead, causing the test to fail. ### What is the New Behavior? Take the `<button>` out of the `<h1>`, and adjust the CSS to remain the same. --------- Co-authored-by: Justin Manion <jmanion32@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12015.
As the linked issue describes, it is possible that an instructor has been in several now-archived courses and wishes to collapse the view of those courses on the homepage to reduce clutter. This pull request adds the ability to toggle the visibility of archived courses, and also spaces the archived courses out visually on the homepage in accordance to the semester for which that course corresponds.
What is the New Behavior?
View of homepage as user
instructorprior to change:View of homepage as user
instructorafter change (visible then hidden):What steps should a reviewer take to reproduce or test the bug or new feature?
Create new terms and courses as described in this documentation. Set those courses to be archived (also as described in this documentation). Log in as
instructor(which is the user that should have been assigned as the instructor for each of the new archived courses); view the homepage. Checkout changes on bothmainandcourse-list-view-archivedto view the differences.Automated Testing & Documentation
Other information