Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12215 +/- ##
=========================================
Coverage 21.71% 21.71%
Complexity 9612 9612
=========================================
Files 268 268
Lines 36073 36070 -3
Branches 475 475
=========================================
Hits 7832 7832
+ Misses 27770 27767 -3
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
williamschen23
previously approved these changes
Nov 17, 2025
Did not see that it was still failing
.contain isn't as strict as have.text. Since we know the issue was called by improper nesting, we can revert to the stricter test.
…nto fix-reg-test
Since I added a div for flex grow, I need to adjust the login test, which relies on #courses > div > h1, to become #courses > div > div > h1
JManion32
approved these changes
Nov 19, 2025
Contributor
JManion32
left a comment
There was a problem hiding this comment.
The registration test is passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
CI is failing due to
registration.spec.js. This was caused in #12154 from nesting a<button>inside of an<h1>element, so when Cypress went to assert that the header said "My Courses", it returned "My Courses " instead, causing the test to fail.What is the New Behavior?
Take the
<button>out of the<h1>, and adjust the CSS to remain the same.