[Feature:InstructorUI] Filter Withdrawn Students#11036
[Feature:InstructorUI] Filter Withdrawn Students#11036
Conversation
fiter withdrawn student in checkpoint/numeric lab and detail grading page
Co-authored-by: Cameron Peterson <46759635+IDzyre@users.noreply.github.com>
….com/Submitty/Submitty into remove-withdraw-students-from-TAview
….com/Submitty/Submitty into remove-withdraw-students-from-TAview
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11036 +/- ##
============================================
+ Coverage 11.66% 19.41% +7.75%
- Complexity 0 9096 +9096
============================================
Files 28 235 +207
Lines 4631 32306 +27675
Branches 460 460
============================================
+ Hits 540 6273 +5733
- Misses 3635 25577 +21942
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This still needs a functionality review and initial approval before maintainer review. Moving back to "Seeking Reviewer". |
ajiang024
left a comment
There was a problem hiding this comment.
This works as specified in the testing instructions. I tested the functions for both TAs and instructors, and for both of them, the withdrawn students are correctly filtered when the box is checked off.
I would recommend someone with more PHP experience to review the code. Testing-wise, it looks good to me.
polibear21
left a comment
There was a problem hiding this comment.
I followed the testing instructions and the website functions exactly as described in the pull request. When I check the box of "Hide withdrawn students", students withdrawn from the course do not show up in the list. Someone with more PHP experience should review the exact PHP code. The UI and functionality of the PR looks good.
williamjallen
left a comment
There was a problem hiding this comment.
This work looks pretty good overall and should be good to merge once these minor nitpick comments are resolved. Please also improve the PR description. The PR should clearly list before and after screenshots, along with a clear description of the work completed. Please also use a GitHub keyword like "closes #xyx" to automatically close the issue linked in the PR description when this gets merged.
site/public/js/details.js
Outdated
| const anon_status = $('[data-testid="toggle-anon-button"]'); | ||
| Cookies.set(`default_anon_mode_${gradeable_id}_override`, 'on'); | ||
| if (Cookies.get(`anon_mode_${gradeable_id}`) === undefined) { | ||
| Cookies.set(`anon_mode_${gradeable_id}`, 'off'); |
There was a problem hiding this comment.
Do you need to set the status of anon_status here? I guess if it defaults to unchecked that's good enough?
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
….com/Submitty/Submitty into withdrawn-students-filter
William-requested changes
Resolved current requested changes, PR still needs work before re-review
The refactor is causing issues to other buttons. This PR adds a new feature. While it would be a positive for our codebase, refactoring the code of the other buttons is beyond the scope of this PR. I'm committing this so I can view the diff.
|
@yanliw123 @Troy-bailan-King To complete this PR, I found it easiest to create a new branch in order to better integrate changes from both this branch and main. #11792 supersedes this one and includes all of your commits. Thank you both for your contributions! |
## Why is this change important / necessary? Closes #11007 , supersedes #11036 TAs and instructors have no way to see if any students are withdrawn or auditing their course, causing unnecessary worry if they are skipping class / missing assignments. ## What is the new behavior? There is now an option to filter auditing/withdrawn students on checkpoint/numeric lab and the detail grading pages. UI Change: This new option is included with other existing toggle buttons such as "View Your Sections" and "Switch to Random Order." Since the location of those buttons restricted the addition of the new "Hide Withdrawn Students" toggle, this PR also refactors the UI by converting the buttons to radios, and moving them to the right where there is more space (see the screenshots below). ## Steps to test 1. login as instructor 2. navigate to the manage students page 3. edit student -> change some several student registration types to withdrawn 4. navigate to a checkpoint/numeric lab, see checkbox 5. navigate to Gradeables -> Grade / Preview Grading -> see filter withdrawn student button 6. test if withdrawn student is filtered, and existing buttons retain functionality ## Before   ## After   --------- Co-authored-by: Yanli Wang <wang970753651@gmail.com> Co-authored-by: Yanli Wang <114595115+yanliw123@users.noreply.github.com> Co-authored-by: Cameron Peterson <46759635+IDzyre@users.noreply.github.com> Co-authored-by: Troy-bailan-King <liny17@rpi.edu> Co-authored-by: Troy-bailan-King <97757033+Troy-bailan-King@users.noreply.github.com> Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
Why is this change important / necessary?
Closes #11007
TAs and instructors have no way to see if any students are withdrawn or auditing their course, causing unnecessary worry if they are skipping class / missing assignments.
What is the new behavior?
There is now an option to filter auditing/withdrawn students on checkpoint/numeric lab and the detail grading pages.
UI Change: This new option is included with other existing toggle buttons such as "View Your Sections" and "Switch to Random Order." Since the location of those buttons restricted the addition of the new "Hide Withdrawn Students" toggle, this PR also refactors the UI by converting the buttons to radios, and moving them to the right where there is more space (see the screenshots below).
Steps to test
Before
After