[Feature:InstructorUI] Filter Withdrawn Students in Gradeables#11792
Merged
[Feature:InstructorUI] Filter Withdrawn Students in Gradeables#11792
Conversation
fiter withdrawn student in checkpoint/numeric lab and detail grading page
Co-authored-by: Cameron Peterson <46759635+IDzyre@users.noreply.github.com>
….com/Submitty/Submitty into remove-withdraw-students-from-TAview
….com/Submitty/Submitty into remove-withdraw-students-from-TAview
You can now filter withdrawn students in simple grading using a checkbox. The logic is very similar to a standard gradeable's. Additionally, the cookie used to filter withdrawn students is the same between the 2, so if you toggle one, it is automatically toggled in the other.
Instead of buttons, gradeables now use checkboxes. Logic is nearly set, just need some work with checkbox UI and cookies on page load.
Checkboxes are now fully functional for gradeables. Withdrawn students are always hidden when grade inquiries only is toggled.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11792 +/- ##
============================================
- Coverage 20.67% 20.67% -0.01%
- Complexity 9176 9177 +1
============================================
Files 263 263
Lines 35222 35223 +1
Branches 461 461
============================================
Hits 7282 7282
- Misses 27483 27484 +1
Partials 457 457
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Filter withdrawn students was set to be instructor only, but should be all non-student graders. This was causing Cypress to fail on page load since we check if each box is checked. This will likely need further improvement to validate permissions on reload so we never check for a box that is not visible on the page.
The function that ensures the right checkboxes are toggled on page load assumed all graders had the same permissions, reading to reference errors, and failing Cypress tests. Now, the function considers these permissions. Additionally, the withdrawn students toggle is no longer displayed for team work. Instead, it is set to on for everyone.
Will do the rest of the Cypress tomorrow.
Adjusted simple grading permissions to always hide withdrawn students. Also made the logic between the 2 functions as similar as possible to maintain continuity
Rather than hiding withdrawn students whenever a grade inquiry is toggled, Instructors can now see withdrawn students with active grade inquiries. Accomplished by overriding hide() and show() with a CSS class and 1 instance of !important
Hide Withdrawn Students is now the bottom checkbox for both types of gradeables
jeffrey-cordero
approved these changes
Jun 27, 2025
Contributor
jeffrey-cordero
left a comment
There was a problem hiding this comment.
The changes implemented for the withdrawn students feature look good. The components for anonymous, withdrawn, default/random ordering, and section selection also appear much clearer for all graders on this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change important / necessary?
Closes #11007 , supersedes #11036
TAs and instructors have no way to see if any students are withdrawn or auditing their course, causing unnecessary worry if they are skipping class / missing assignments.
What is the new behavior?
There is now an option to filter auditing/withdrawn students on checkpoint/numeric lab and the detail grading pages.
UI Change: This new option is included with other existing toggle buttons such as "View Your Sections" and "Switch to Random Order." Since the location of those buttons restricted the addition of the new "Hide Withdrawn Students" toggle, this PR also refactors the UI by converting the buttons to radios, and moving them to the right where there is more space (see the screenshots below).
Steps to test
Before
After