Closed
Conversation
7190169 to
8baa519
Compare
423d9b4 to
173dde2
Compare
Member
Author
|
The pants-managed venv does not have PyOpenSSL.
I don't know if that's related to the timeouts in the integration tests or not. Nope. That's irrelevant because we're already pinned to requests==2.25.1, so we're only getting pyopenssl because of our pin now. If we dropped that it would probably go away. We can also drop the |
75b3502 to
fdedead
Compare
GHA isn't failing with the RabbitMQ errors anymore. Hopefully the hack isn't actually needed. Lockfile diff: lockfiles/st2.lock [st2] == Removed dependencies == pyopenssl 24.1.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == amqp 5.0.6 --> 5.2.0 vine 5.0.0 --> 5.1.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == bcrypt 3.2.2 --> 4.1.2
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == greenlet 1.1.3.post0 --> 3.0.3
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == tenacity 6.3.1 --> 8.2.3
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == oslo-utils 4.13.0 --> 7.1.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == cffi 1.14.6 --> 1.16.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == kombu 5.0.2 --> 5.3.6 == Added dependencies == typing-extensions 4.11.0
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == stevedore 2.0.1 --> 5.2.0
cognifloyd
added a commit
that referenced
this pull request
Apr 10, 2024
Using the pants venv, the tests all pass with these requirements. I hacked the Makefile to test that in CI in #6130. This extracts just the requirements bits from that PR. Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == amqp 5.0.6 --> 5.2.0 bcrypt 3.2.0 --> 4.1.2 cffi 1.14.6 --> 1.16.0 eventlet 0.30.3 --> 0.36.1 filelock 3.13.3 --> 3.13.4 kombu 5.2.2 --> 5.3.6 oslo-utils 4.13.0 --> 7.1.0 stevedore 2.0.1 --> 5.2.0 tenacity 6.3.1 --> 8.2.3 vine 5.0.0 --> 5.1.0 == Added dependencies == typing-extensions 4.11.0
Merged
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
By default, pants+pex adds `-sE` to the virtualenv/bin scripts which prevents PYTHONPATH and other PYTHON* vars from affecting the program. st2-run-pack-tests uses PYTHONPATH, however, so bypass the script if it is hermetic.
to make sure this new method works for running nosetests.
This was referenced Apr 15, 2024
Member
Author
|
Closing. The requirements changes have already been merged and the remaining changes were implemented in a cleaner way in other PRs that have been merged and will be merged. The branch will still be available if someone needs to consult changes made to the Makefile or similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't intend to merge this. I want to use this to find any issues with the requirements pants is using and limit them appropriately. So, the changes to the Makefile are quite hacky.