Disable requests[security] and remove 3.5 support references#5867
Merged
nateprewitt merged 1 commit intopsf:masterfrom Jul 9, 2021
Merged
Disable requests[security] and remove 3.5 support references#5867nateprewitt merged 1 commit intopsf:masterfrom
nateprewitt merged 1 commit intopsf:masterfrom
Conversation
sethmlarson
requested changes
Jul 9, 2021
Member
sethmlarson
left a comment
There was a problem hiding this comment.
Looks good! Only thing I found was we should update python_requires to add !=3.5.*
2d6e35f to
8bddbfd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requests[security]
This PR will remove functionality from the
requests[security]extra. We initially removed default support for PyOpenSSL in Requests 2.24.0 (#5443) as it is now considered less secure. Deprecation of theextras_requirewas announced in Requests 2.25.0 and we're officially removing theextras_requirefunctionality in Requests 2.26.0.Projects currently using
requests[security]after this change will continue to operate as if performing a standard requests installation (secure by default).While not recommended, if PyOpenSSL support is still a requirement in your project, you may install
urllib3[secure]and addurllib3.contrib.pyopenssl.inject_into_urllib3()to your code to re-enable the functionality.Python 3.5 Support
We will also be removing support for Python 3.5 in Requests 2.26.0 as announced in the 2.25.0 release notes.