Conversation
Owner
Author
|
@MattMills Could you try this PR to see if it works well? |
cec5ae4 to
5ecb729
Compare
Owner
Author
|
I'm gonna merge it for now since it's been unresponsive for a long time. @MattMills Please feel free to reply or open an issue if you have any questions. |
SpriteOvO
added a commit
that referenced
this pull request
Sep 11, 2023
SpriteOvO
added a commit
that referenced
this pull request
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements signature runtime parsing feature requested in #4.
With this feature added, users will be able to parse runtime signature strings using a new static member function
signature::parse.To use this optional feature, define the configuration macro
SIGMATCH_ENABLE_SIGNATURE_RUNTIME_PARSINGbefore includingsigmatch.hpp.Since this library currently lacks a good error handling implementation, the new static member function
signature::parsereturns astd::optional<signature>, which contains asignatureif parsing is successful, or it is astd::nulloptif it encounters an error while parsing. After a good error handling is implemented in the future, the return type of this function will be changed for returning the reason when parsing fails.