Linting for set SpacemanDMM_ statements that have no effect#435
Merged
SpaceManiac merged 3 commits intoSpaceManiac:masterfrom Jun 23, 2025
Merged
Linting for set SpacemanDMM_ statements that have no effect#435SpaceManiac merged 3 commits intoSpaceManiac:masterfrom
SpaceManiac merged 3 commits intoSpaceManiac:masterfrom
Conversation
github-merge-queue bot
pushed a commit
to cmss13-devs/cmss13
that referenced
this pull request
Jun 26, 2025
# About the pull request This PR (in addition to #9762) fixes a few places where Spacemandmm directives like `SHOULD_CALL_PARENT` were doing nothing but also not emitting any warning. With SpaceManiac/SpacemanDMM#435 they will now be errors. # Explain why it's good for the game Code should not merely be no-ops. # Changelog No player facing changes.
san7890
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Jun 27, 2025
## About The Pull Request SpaceManiac/SpacemanDMM#435 added a new dreamchecker lint, for SDMM `set` statements not at the top of the proc. While this lint isn't in the current SDMM _release_, I was testing it out earlier and saw these issues, so might as well fix them before they even become an issue. i also fixed a useless variable in moon heretic code that was right next to the incorrectly placed `SIGNAL_HANDLER` ## Why It's Good For The Game https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3 ## Changelog No player-facing changes.
TealSeer
pushed a commit
to Bubberstation/Bubberstation
that referenced
this pull request
Jun 29, 2025
## About The Pull Request SpaceManiac/SpacemanDMM#435 added a new dreamchecker lint, for SDMM `set` statements not at the top of the proc. While this lint isn't in the current SDMM _release_, I was testing it out earlier and saw these issues, so might as well fix them before they even become an issue. i also fixed a useless variable in moon heretic code that was right next to the incorrectly placed `SIGNAL_HANDLER` ## Why It's Good For The Game https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3 ## Changelog No player-facing changes. (cherry picked from commit a2a43e2)
Iajret
pushed a commit
to Iajret/LizardsPurgatory
that referenced
this pull request
Aug 1, 2025
## About The Pull Request SpaceManiac/SpacemanDMM#435 added a new dreamchecker lint, for SDMM `set` statements not at the top of the proc. While this lint isn't in the current SDMM _release_, I was testing it out earlier and saw these issues, so might as well fix them before they even become an issue. i also fixed a useless variable in moon heretic code that was right next to the incorrectly placed `SIGNAL_HANDLER` ## Why It's Good For The Game https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3 ## Changelog No player-facing changes.
TealSeer
pushed a commit
to effigy-se/effigy
that referenced
this pull request
Aug 3, 2025
## About The Pull Request SpaceManiac/SpacemanDMM#435 added a new dreamchecker lint, for SDMM `set` statements not at the top of the proc. While this lint isn't in the current SDMM _release_, I was testing it out earlier and saw these issues, so might as well fix them before they even become an issue. i also fixed a useless variable in moon heretic code that was right next to the incorrectly placed `SIGNAL_HANDLER` ## Why It's Good For The Game https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3 ## Changelog No player-facing changes.
Floofies
pushed a commit
to Floofies/NovaSector
that referenced
this pull request
Aug 5, 2025
## About The Pull Request SpaceManiac/SpacemanDMM#435 added a new dreamchecker lint, for SDMM `set` statements not at the top of the proc. While this lint isn't in the current SDMM _release_, I was testing it out earlier and saw these issues, so might as well fix them before they even become an issue. i also fixed a useless variable in moon heretic code that was right next to the incorrectly placed `SIGNAL_HANDLER` ## Why It's Good For The Game https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3 ## Changelog No player-facing changes.
Kocma-san
pushed a commit
to Fluffy-Frontier/FluffySTG
that referenced
this pull request
Aug 13, 2025
## About The Pull Request SpaceManiac/SpacemanDMM#435 added a new dreamchecker lint, for SDMM `set` statements not at the top of the proc. While this lint isn't in the current SDMM _release_, I was testing it out earlier and saw these issues, so might as well fix them before they even become an issue. i also fixed a useless variable in moon heretic code that was right next to the incorrectly placed `SIGNAL_HANDLER` ## Why It's Good For The Game https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3 ## Changelog No player-facing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a spaceman setting like
SHOULD_CALL_PARENTcomes after some other statement other than possibly another setting, it is silently ignored. This PR now errors in that situation. The checking is only performed on spaceman settings and not built in settings (e.g.background) because those can situationally be allowed in control statements so long as they otherwise would be at the top of the proc, but dreammaker will already warn for them if they would have no effect.See below where red lined are the new lints, and yellow lined are the existing dreammaker warnings.
