Fix a few ignored spacemandmm directives#9764
Merged
Detective-Google merged 1 commit intocmss13-devs:masterfrom Jun 26, 2025
Merged
Fix a few ignored spacemandmm directives#9764Detective-Google merged 1 commit intocmss13-devs:masterfrom
Detective-Google merged 1 commit intocmss13-devs:masterfrom
Conversation
Detective-Google
approved these changes
Jun 21, 2025
fira
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR (in addition to #9762) fixes a few places where Spacemandmm directives like
SHOULD_CALL_PARENTwere doing nothing but also not emitting any warning. With SpaceManiac/SpacemanDMM#435 they will now be errors.Explain why it's good for the game
Code should not merely be no-ops.
Changelog
No player facing changes.