Add compatibility with Forge's update checker and Catalogue modmenu#1933
Merged
Su5eD merged 1 commit intoSinytra:1.20.1from Sep 10, 2025
Merged
Add compatibility with Forge's update checker and Catalogue modmenu#1933Su5eD merged 1 commit intoSinytra:1.20.1from
Su5eD merged 1 commit intoSinytra:1.20.1from
Conversation
…`forgeUpdateJSONURL`) + Added compatibility with the Catalogue modmenu (submit bug url)
Su5eD
approved these changes
Sep 10, 2025
Member
|
Thanks for the PR. If possible, feel free to port this to 1.21.1 as well and I'll include it in the upcoming release.
This is actually a good idea to add, especially now that we have a dedicated website for Connector. I'll definitely give it a shot. |
Su5eD
added a commit
that referenced
this pull request
Sep 11, 2025
Port of #1933 Co-authored-by: nergizer <86924836+nergizer@users.noreply.github.com>
Su5eD
added a commit
that referenced
this pull request
Sep 29, 2025
* Start beta 10, perform routine maintenance * Fix ffloader impl change * Wrap thread factory set context class loader in a try (#1771) * Propagate issue tracker link to bridged mods.toml Port of #1933 Co-authored-by: nergizer <86924836+nergizer@users.noreply.github.com> * Check LoadingModList#hasErrors instead of LoadingModList#getModLoadingIssues != empty (#1830) this makes Connector only check for true mod loading errors instead of non-fatal warnings, which prevents difficult-to-debug crashes due to Connector not running early setup despite the game continuing to launch Signed-off-by: unilock <unilock@fennet.rentals> * Implement Adapter UTP transforms Fixed issues related to Polymer Fixes #1333 Fixes #1734 * Silence mixin errors from unused mixins * Update adapter definition to 1.13.37 Fixes Cinderscapes * Display Connector version in debug overlay Update adapter definition to 1.13.38 * Update README * Don't crash if moving module fails * Update adapter definition to 1.13.40 Fixes #1384 * Make PLUGIN modules read connector Fixes #1966 * Update adapter to 1.13.42 Fixes #1922 * Always show loading errors Fixes the annoying "requires connector" error again, this time for mods that require fabric mods * Fix lazy entity attribute replacement Fixes #1343 --------- Signed-off-by: unilock <unilock@fennet.rentals> Co-authored-by: Milkev <kmdre@hotmail.com> Co-authored-by: nergizer <86924836+nergizer@users.noreply.github.com> Co-authored-by: Katherine <unilock@fennet.rentals>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compatibility with Forge's update checker (via custom property
forgeUpdateJSONURL) + Added compatibility with the Catalogue modmenu (submit bug url)The Issue
Currently, mods loaded via Connector cannot use (Neo)Forge's update checker. Moreover, the bug tracker URL doesn't seem to be set, which prevents some modmenus like Catalogue from displaying a "Sumbit bug report" button on the mod's page.
The Proposal
This pull request proposes to add support for this update checker by setting the mod's
updateJSONURLto the value of a custom attribute in itsfabric.mod.jsonnamedforgeUpdateJSONURL.Also, the
issueTrackerURLis set to the value of theissuesfield in the contact information.Possible Side Effects
Probably none. The Forge's update checker will only be used if the mod has a
forgeUpdateJSONURLcustom field in its manifest.Maybe the bug report URL should be changed to a confirmation page about this mod being loaded with Connector (maybe something like https://sinytra.org/connector_warning?redirect_to=).
Alternatives
While most players probably use launchers to manage their mods, adding compatibility with Forge's update checker will also notify players on the main menu (moreover the changes in themselves are pretty small).
Also, making Forge aware of the mod's bug report URL could maybe help in easier bug reports for players (as mentioned in Possible Side Effects maybe it should first redirect to a confirmation page).
Maybe the PR should be split in 2 (one for the Forge update checker and one for the issue tracker) ?
Additional Notes
I'm not a native English speaker, and this is my first public PR
If this PR is successful I will probably also port it to the 1.21.1 branch