[Build Tools] Update RegExps in packaging for npm.#2816
Merged
jlukic merged 1 commit intoSemantic-Org:nextfrom Aug 10, 2015
Merged
[Build Tools] Update RegExps in packaging for npm.#2816jlukic merged 1 commit intoSemantic-Org:nextfrom
jlukic merged 1 commit intoSemantic-Org:nextfrom
Conversation
Fixes npm packaging for components api, site (Semantic-Org#1878) and transition.
Member
|
What modules have you checked the modification against? I know specifically some modules use a different syntax for extending jquery which could have issues with the regex |
Contributor
Author
|
I went through all repos (generated by gulp release) that had an index.js file in there, comparing the files before and after the regex replacements. turns into: |
jlukic
added a commit
that referenced
this pull request
Aug 10, 2015
Update RegExps in packaging for npm.
Member
|
I'll release a patch tomorrow |
jlukic
added a commit
that referenced
this pull request
Aug 10, 2015
jlukic
added a commit
that referenced
this pull request
Aug 10, 2015
Member
|
@davide Do you think it makes sense to leave |
Member
|
Tagging on npm as we speak, let me know if that resolves issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes npm packaging for components api, site (#1878) and transition.
This patch is re-implementation of fixes done in pull request 1156 (#1156) following some concerns raised in #1878.