Fixed npm - replaced hidden module with _module variable#1156
Merged
jlukic merged 1 commit intoSemantic-Org:masterfrom Oct 13, 2014
AnsonT:master
Merged
Fixed npm - replaced hidden module with _module variable#1156jlukic merged 1 commit intoSemantic-Org:masterfrom AnsonT:master
jlukic merged 1 commit intoSemantic-Org:masterfrom
AnsonT:master
Conversation
Closed
jlukic
added a commit
that referenced
this pull request
Oct 13, 2014
Fixed npm - replaced hidden module with _module variable
Member
|
Its surprising using module as a local variable breaks things. |
Contributor
Author
|
Defining the local 'module' variable hides the outer definition. It's hidden for the entire block, not just after it's defined. Thanks for the merge. |
davide
added a commit
to davide/Semantic-UI
that referenced
this pull request
Oct 25, 2014
…form behavior
With this fix one needs to explicitely define:
$.fn.form = require('semantic-ui/npm/modules/behavior/form');
|
Why is |
Member
Contributor
|
@hungryzi pull request 2816 (linked above) will correctly export transition as a module. Not sure when the next npm release is due though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm packages do not work because the module exports variable is hidden by the locally defined module variable within the functions - module.exports.settings is undefined. This fix adds a _module alias. A better but more involved fix is to not use module as local variable name, but that requires changing all the js files.