fix: wrong detection of useless statements that call parameters/unknown callables#790
Merged
lars-reimann merged 10 commits intomainfrom Nov 22, 2023
Merged
Conversation
…ers as impurity reason
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 84 84
Lines 12989 13039 +50
Branches 2726 2738 +12
=========================================
+ Hits 12989 13039 +50 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [0.4.0](v0.3.0...v0.4.0) (2023-11-22) ### Features * add endless recursion as an impurity reason ([#788](#788)) ([98acdde](98acdde)) * call graph computer (without closures) ([#782](#782)) ([34bf182](34bf182)) * check types of constant parameters ([#775](#775)) ([0a02850](0a02850)), closes [#668](#668) * check whether purity of callable parameters of functions is set properly ([#777](#777)) ([f8fd907](f8fd907)), closes [#732](#732) * compute purity/side effects for expressions ([#785](#785)) ([9ed1c08](9ed1c08)), closes [#15](#15) * compute types of parameters of lambdas that are passed as default value ([#780](#780)) ([01a5c03](01a5c03)) * error if call leads to infinite recursion ([#783](#783)) ([f7eabd8](f7eabd8)), closes [#667](#667) * error if impure callable is passed to pure parameter ([#792](#792)) ([5536a4a](5536a4a)), closes [#730](#730) * error if parameter name in impurity reason is invalid ([#772](#772)) ([faa2012](faa2012)), closes [#741](#741) * error if purity of functions is not specified ([#768](#768)) ([a15b0af](a15b0af)), closes [#731](#731) * filter statements without effect for code generation ([#786](#786)) ([cd4f2c1](cd4f2c1)), closes [#542](#542) * improve location of warning about duplicate annotation target ([#771](#771)) ([87d2a48](87d2a48)) * info if `@Pure` annotation is called on parameter of pure function ([#778](#778)) ([c15c70e](c15c70e)) * purity computer ([#784](#784)) ([b09bb3a](b09bb3a)) * remove type parameters from enum variants ([#767](#767)) ([cb6556a](cb6556a)), closes [#766](#766) * short-circuit `and`, `or`, and `?:` if RHS has no side effects ([#789](#789)) ([9d9f4b7](9d9f4b7)), closes [#15](#15) * streamline purity information ([#779](#779)) ([75a9e5b](75a9e5b)) * stricter definition of `const` parameters ([#776](#776)) ([73a0d4e](73a0d4e)) * update snippets for functions and methods ([#769](#769)) ([061d3b1](061d3b1)) * validate impurity reasons of overriding methods ([#774](#774)) ([71fc5bd](71fc5bd)), closes [#665](#665) * warn about duplicate impurity reasons ([#773](#773)) ([8344356](8344356)), closes [#733](#733) * warn if statement has no effect ([#787](#787)) ([6f45dc4](6f45dc4)), closes [#664](#664) ### Bug Fixes * signature help for optional parameters ([#793](#793)) ([fd88ce8](fd88ce8)), closes [#791](#791) * wrong detection of useless statements that call parameters/unknown callables ([#790](#790)) ([a49b4b3](a49b4b3)) * wrong`"assignment/nothing-assigned"` error if RHS calls expression lambda ([#781](#781)) ([b909cb8](b909cb8))
Member
Author
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Statements that called parameters (with unknown value) or unknown callables were wrongly marked as unused. Because if this, an incorrect warning was shown and no code was generated for them.