Merge branch 'microsoft:main' into Web-Search-Plugin-Enhanced-Responses#3
Closed
SOE-YoungS wants to merge 5 commits intomainfrom
Closed
Merge branch 'microsoft:main' into Web-Search-Plugin-Enhanced-Responses#3SOE-YoungS wants to merge 5 commits intomainfrom
SOE-YoungS wants to merge 5 commits intomainfrom
Conversation
….com/SOE-YoungS/semantic-kernel into Web-Search-Plugin-Enhanced-Responses
…ft#3354) ### Motivation and Context Two properties were inadvertently made public and should be private ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
SOE-YoungS
pushed a commit
that referenced
this pull request
Nov 1, 2023
…se AIRequestSettings) (microsoft#2829) ### Motivation and Context Currently the SK core uses a model for LLM request settings which is OpenAI specific. This is a refactor to remove this assumption and to allow SK to be LLM agnostic. Resolves: microsoft#2735 ### Description 1. Remove `ChatRequestSettings` and `CompleteRequestSettings` and use new class `AIRequestSettings` instead 1. Create default OpenAI request settings class `OpenAIRequestSetings` which extends `AIRequestSettings`. 1. Fix up planner, unit tests and integration tests 1. Add a new Kernel syntax example showing all options to configure LLM request settings ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
SOE-YoungS
pushed a commit
that referenced
this pull request
Nov 1, 2023
…se AIRequestSettings) (microsoft#2829) ### Motivation and Context Currently the SK core uses a model for LLM request settings which is OpenAI specific. This is a refactor to remove this assumption and to allow SK to be LLM agnostic. Resolves: microsoft#2735 ### Description 1. Remove `ChatRequestSettings` and `CompleteRequestSettings` and use new class `AIRequestSettings` instead 1. Create default OpenAI request settings class `OpenAIRequestSetings` which extends `AIRequestSettings`. 1. Fix up planner, unit tests and integration tests 1. Add a new Kernel syntax example showing all options to configure LLM request settings ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist