Skip to content

.Net: Reduce visibility of two fields from public to private#3354

Merged
markwallace-microsoft merged 2 commits intomicrosoft:mainfrom
markwallace-microsoft:users/markwallace/fix-field-visibility
Nov 1, 2023
Merged

.Net: Reduce visibility of two fields from public to private#3354
markwallace-microsoft merged 2 commits intomicrosoft:mainfrom
markwallace-microsoft:users/markwallace/fix-field-visibility

Conversation

@markwallace-microsoft
Copy link
Member

Motivation and Context

Two properties were inadvertently made public and should be private

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner October 31, 2023 23:32
@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Oct 31, 2023
@github-actions github-actions bot changed the title Reduce visibility of two fields from public to private .Net: Reduce visibility of two fields from public to private Oct 31, 2023
Copy link
Member

@rogerbarreto rogerbarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be flagged as a breaking change.

@rogerbarreto rogerbarreto added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Nov 1, 2023
@markwallace-microsoft markwallace-microsoft added the PR: breaking change Pull requests that introduce breaking changes label Nov 1, 2023
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Nov 1, 2023
Merged via the queue into microsoft:main with commit 746b421 Nov 1, 2023
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/fix-field-visibility branch November 1, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code PR: breaking change Pull requests that introduce breaking changes PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants