Chore: Restrict legacy message events#27691
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27691 +/- ##
===========================================
- Coverage 42.42% 42.25% -0.18%
===========================================
Files 811 813 +2
Lines 17133 17182 +49
Branches 1909 1920 +11
===========================================
- Hits 7269 7260 -9
- Misses 9626 9682 +56
- Partials 238 240 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
approved these changes
Jan 10, 2023
aleksandernsilva
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Code review only. More info is needed to be able to test functionality.
gabriellsh
added a commit
that referenced
this pull request
Jan 11, 2023
…customRolesUpsell * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Composer Toolbox overlapping borders (#27714) [FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component (#27533) [FIX] Discussion visibility when inside a private team. (#27601) Chore: Restrict legacy message events (#27691) [FIX] Anonymous user buttons (#27551) [BREAK] [FIX] VideoConference Ringer working intermittently on microservices (#27703) [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR aims to fix conflicts between the legacy messages and the new ones, specially click events on threads.
Issue(s)
Closes #27698
Steps to test or reproduce
Further comments
The
codecov/patchcheck is expected to fail because we actively are not testing messages in the legacy format; it can be safely ignored.