[FIX] Anonymous user buttons#27551
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27551 +/- ##
===========================================
+ Coverage 40.92% 42.48% +1.56%
===========================================
Files 837 811 -26
Lines 17647 17133 -514
Branches 1984 1909 -75
===========================================
+ Hits 7222 7279 +57
+ Misses 10186 9611 -575
- Partials 239 243 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
requested changes
Dec 20, 2022
gabriellsh
left a comment
Member
There was a problem hiding this comment.
Nice work, this fixes it, but can you add E2E tests for it? Seems like an easy win.
ggazzo
reviewed
Dec 29, 2022
gabriellsh
previously approved these changes
Jan 3, 2023
tassoevan
requested changes
Jan 9, 2023
tassoevan
approved these changes
Jan 10, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 11, 2023
…customRolesUpsell * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Composer Toolbox overlapping borders (#27714) [FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component (#27533) [FIX] Discussion visibility when inside a private team. (#27601) Chore: Restrict legacy message events (#27691) [FIX] Anonymous user buttons (#27551) [BREAK] [FIX] VideoConference Ringer working intermittently on microservices (#27703) [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When the server accepts an anonymous user to join and chat without login, two buttons appears: one for Login and the other to send messages without login.
The component was rewritten to use the fuselage Design System and native hooks to perform actions.
Issue(s)
closes #27149
fixes https://forums.rocket.chat/t/sign-in-to-start-talking-and-or-talk-as-anonymous-buttons-dont-work/15358
Steps to test or reproduce
Further comments
TC-318