Skip to content

Conversation

@tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It migrates client/sidebar/header/actions/Search component to TypeScript and mitigates a invalid call to Array.prototype.every:

image

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested review from a team and rique223 January 21, 2022 00:02
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tassoevan tassoevan merged commit a91e8a3 into develop Jan 21, 2022
@tassoevan tassoevan deleted the fix/use-outside-click-usage branch January 21, 2022 01:04
gabriellsh added a commit that referenced this pull request Jan 25, 2022
…age-template-2

* 'develop' of github.com:RocketChat/Rocket.Chat: (81 commits)
  Language update from LingoHub 🤖 (#24268)
  Regression: Fix incompatibility of apps http requests (#24276)
  [IMPROVE] lib/Statistics improved and metrics collector (#24177)
  [FIX] Fixing the changing custom status behavior (#24218)
  Regression: Align Omni-Source icon sizes with designs (#24269)
  Regression: Fix Inactive Departments still visible on Livechat (#24267)
  [FIX] Solved Report Message Blank (#24262)
  [FIX] Errors on advanced sync prevent LDAP users from logging in (#23958)
  Chore: Convert model LoginServiceConfiguration to raw (#24187)
  [FIX] Make canned responses popup dependent on Canned_responses_enabled setting (#23804)
  [FIX] Wrong german translation for 2FA-Promt (#24126)
  Bump follow-redirects from 1.14.5 to 1.14.7 in /ee/server/services (#24182)
  Chore: Update pino and pino-pretty (#24242)
  [FIX] Avoid updating all rooms with visitor abandonment queries (#24252)
  Add: Alpine image as option for build (#12548)
  Fixed broken links in setup wizard (#24248)
  [FIX] Apps Contextual Bar not carrying title and room information   (#24241)
  Chore: Bump fuselage hooks (#24233)
  Regression: Remove extra call to `useOutsideClick` hook not following the function signature (#24243)
  [FIX] Change canned response model index to match other definition (#24235)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants