[FIX] Make canned responses popup dependent on Canned_responses_enabled setting #23804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Nov 26, 2021
Member
sampaiodiego
left a comment
There was a problem hiding this comment.
you should be able to change addMessagePopup so it can be used inside reactive functions.
Member
Author
This was exactly what i was looking for, thanks man! |
sampaiodiego
requested changes
Nov 30, 2021
Comment on lines
6
to
8
| const nonReactiveGetFunc = function() { | ||
| return customMessagePopups.get(); | ||
| }; |
Member
There was a problem hiding this comment.
since you named this function "nonReactive" why don't you make it non-reactive for real? 😬
Suggested change
| const nonReactiveGetFunc = function() { | |
| return customMessagePopups.get(); | |
| }; | |
| const nonReactiveGetFunc = () => Tracker.nonreactive(() => customMessagePopups.get()); |
Member
Author
There was a problem hiding this comment.
This is what I get for naming things like that lol (i'll do the change)
sampaiodiego
approved these changes
Dec 1, 2021
|
|
sampaiodiego
requested changes
Dec 20, 2021
ee/app/canned-responses/client/views/popup/addMessagePopupCannedResponse.js
Outdated
Show resolved
Hide resolved
ee/app/canned-responses/client/views/popup/addMessagePopupCannedResponse.js
Outdated
Show resolved
Hide resolved
sampaiodiego
previously approved these changes
Dec 20, 2021
…f github.com:RocketChat/Rocket.Chat into fix/make-canned-responses-popup-dependent-on-setting
cauefcr
approved these changes
Jan 19, 2022
Contributor
cauefcr
left a comment
There was a problem hiding this comment.
Looking good to me, approving.
gabriellsh
added a commit
that referenced
this pull request
Jan 25, 2022
…age-template-2 * 'develop' of github.com:RocketChat/Rocket.Chat: (81 commits) Language update from LingoHub 🤖 (#24268) Regression: Fix incompatibility of apps http requests (#24276) [IMPROVE] lib/Statistics improved and metrics collector (#24177) [FIX] Fixing the changing custom status behavior (#24218) Regression: Align Omni-Source icon sizes with designs (#24269) Regression: Fix Inactive Departments still visible on Livechat (#24267) [FIX] Solved Report Message Blank (#24262) [FIX] Errors on advanced sync prevent LDAP users from logging in (#23958) Chore: Convert model LoginServiceConfiguration to raw (#24187) [FIX] Make canned responses popup dependent on Canned_responses_enabled setting (#23804) [FIX] Wrong german translation for 2FA-Promt (#24126) Bump follow-redirects from 1.14.5 to 1.14.7 in /ee/server/services (#24182) Chore: Update pino and pino-pretty (#24242) [FIX] Avoid updating all rooms with visitor abandonment queries (#24252) Add: Alpine image as option for build (#12548) Fixed broken links in setup wizard (#24248) [FIX] Apps Contextual Bar not carrying title and room information (#24241) Chore: Bump fuselage hooks (#24233) Regression: Remove extra call to `useOutsideClick` hook not following the function signature (#24243) [FIX] Change canned response model index to match other definition (#24235) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments