[FIX] Startup error when using MongoDB with a password containing special characters#19749
Merged
Merged
Conversation
rodrigok
previously approved these changes
Dec 3, 2020
rodrigok
approved these changes
Dec 3, 2020
Merged
gabriellsh
added a commit
that referenced
this pull request
Dec 8, 2020
…r_render * 'header' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Replace useClipboard (#19764) Regression: contextualBar folder structure (#19761) [IMPROVE] Replace usePrefersReducedMotion (#19759) [FIX] Image preview for image URLs on messages (#19734) [FIX] Sidebar presence will now correctly update for Omnichannel rooms (#19746) Fix OTR tab [FIX] Startup error when using MongoDB with a password containing special characters (#19749) [FIX] File Tab Order (#19729) [FIX] Emails not showing up in Admin/Users (#19727) Regression: Add Members showing the wrong template (#19748) Regression: "My Account" page doesn't load (#19753) [FIX] Add fallback message when show notification content is disabled (#19516) Frontend folder structure (#19631) bump fuselage (#19736) [IMPROVE] Removed useEndpointDataExperimental hook usage (#19496) Merge EE and Community translations and LingoHub manual sync (#19723) [FIX] Sidebar UI disappearing (#19725) [IMPROVE] Rewrite NotificationPreferences to React component (#19672) Skeleton Fix buttons
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Looks like the URL parser we were importing from
mongodb/lib/url_parseris the legacy URL parser, the new one is the default since driver version 3.3.3 (mongodb/node-mongodb-native@52d76e3) so we should use it, as this is the parser used to create connections everywhere else.The main issue with the legacy parser is that it doesn't support encoded characters like
P%24ssw0rd%21, showing an error like this on startup:Using the new parser fixes that.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments