Skip to content

[FIX] Image preview for image URLs on messages#19734

Merged
sampaiodiego merged 5 commits into
developfrom
fix/image-previews
Dec 4, 2020
Merged

[FIX] Image preview for image URLs on messages#19734
sampaiodiego merged 5 commits into
developfrom
fix/image-previews

Conversation

@gabrieleiro

Copy link
Copy Markdown
Contributor

Proposed changes

Add a null check to prevent an exception to stop the image preview workflow.

Issue(s)

Closes #19714

How to test or reproduce

  1. Go to any channel or DM
  2. Paste an image url

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

[FIX] Image previews not working

Further comments

@sampaiodiego sampaiodiego self-requested a review December 2, 2020 18:54
Comment thread tests/end-to-end/api/05-chat.js Outdated
Comment thread tests/end-to-end/api/05-chat.js Outdated
Comment thread tests/end-to-end/api/05-chat.js Outdated
@sampaiodiego sampaiodiego changed the title [FIX] Image preview doesn't work [FIX] Image preview for image URLs on messages Dec 4, 2020
@sampaiodiego sampaiodiego merged commit 90d49a5 into develop Dec 4, 2020
@sampaiodiego sampaiodiego deleted the fix/image-previews branch December 4, 2020 21:42
@sampaiodiego sampaiodiego added this to the 3.9.1 milestone Dec 4, 2020
@sampaiodiego sampaiodiego mentioned this pull request Dec 5, 2020
gabriellsh added a commit that referenced this pull request Dec 8, 2020
…r_render

* 'header' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Replace useClipboard (#19764)
  Regression: contextualBar folder structure (#19761)
  [IMPROVE] Replace usePrefersReducedMotion (#19759)
  [FIX] Image preview for image URLs on messages (#19734)
  [FIX] Sidebar presence will now correctly update for Omnichannel rooms (#19746)
  Fix OTR tab
  [FIX] Startup error when using MongoDB with a password containing special characters (#19749)
  [FIX] File Tab Order (#19729)
  [FIX] Emails not showing up in Admin/Users (#19727)
  Regression: Add Members showing the wrong template  (#19748)
  Regression: "My Account" page doesn't load (#19753)
  [FIX] Add fallback message when show notification content is disabled (#19516)
  Frontend folder structure (#19631)
  bump fuselage (#19736)
  [IMPROVE] Removed useEndpointDataExperimental hook usage (#19496)
  Merge EE and Community translations and LingoHub manual sync (#19723)
  [FIX] Sidebar UI disappearing (#19725)
  [IMPROVE] Rewrite NotificationPreferences to React component (#19672)
  Skeleton
  Fix buttons
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image preview stopped working - 3.9.0

2 participants