[NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats #17335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
requested changes
Apr 17, 2020
Contributor
renatobecker
left a comment
There was a problem hiding this comment.
@MarcosSpessatto I was wondering that we could add an additional feature that would improve the UX on the visitor Forward template, right here:
We already have a departmentConditions helper method that allows the select just valid departments. I think that we could use that method to filter only valid departments, I mean, in case the current room department has a list of restricted department to transfer, we could filter just those departments, what do you think?
Obviously, since the feature is enterprise and the template where the input is available is community, you would need to implement a way to get this eventual additional filter somehow.
...livechat-enterprise/client/views/app/customTemplates/livechatDepartmentCustomFieldsForm.html
Outdated
Show resolved
Hide resolved
ee/app/livechat-enterprise/server/hooks/afterRemoveDepartment.js
Outdated
Show resolved
Hide resolved
ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.js
Outdated
Show resolved
Hide resolved
ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.js
Outdated
Show resolved
Hide resolved
ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.js
Outdated
Show resolved
Hide resolved
ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.js
Outdated
Show resolved
Hide resolved
ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.js
Outdated
Show resolved
Hide resolved
renatobecker
requested changes
Apr 18, 2020
added 4 commits
April 20, 2020 10:56
renatobecker
requested changes
Apr 20, 2020
| data() { | ||
| return Template.instance().room; | ||
| const departmentForwardRestrictions = Template.instance().departmentForwardRestrictions.get(); | ||
| console.log(departmentForwardRestrictions); |
Contributor
There was a problem hiding this comment.
We don't need this console here =D
| this.departments = new ReactiveVar([]); | ||
| this.selectedAgents = new ReactiveVar([]); | ||
| this.selectedDepartments = new ReactiveVar([]); | ||
| this.departmentForwardRestrictions = new ReactiveVar(); |
Contributor
There was a problem hiding this comment.
Suggested change
| this.departmentForwardRestrictions = new ReactiveVar(); | |
| this.departmentForwardRestrictions = new ReactiveVar({}); |
| Meteor.methods({ | ||
| 'livechat:getDepartmentForwardRestrictions'(departmentId) { | ||
| if (!Meteor.userId()) { | ||
| throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'livechat:getTagsList' }); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'livechat:getTagsList' }); | |
| throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'livechat:getDepartmentForwardRestrictions' }); |
| if (!departmentId) { | ||
| return {}; | ||
| } | ||
| const department = LivechatDepartment.findOneById(departmentId); |
Contributor
There was a problem hiding this comment.
Suggested change
| const department = LivechatDepartment.findOneById(departmentId); | |
| const department = LivechatDepartment.findOneById(departmentId, { fields: { departmentsAllowedToForward: 1 } }); |
renatobecker
approved these changes
Apr 20, 2020
gabriellsh
added a commit
that referenced
this pull request
Apr 22, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] 2FA not showing codes for Spanish translation (#17378) [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users (#17333) [NEW] Federation event for when users left rooms (#17091) [FIX] CSV Importer fails when there are no users to import (#16790) Import slack's mpims as direct rooms instead of private groups (#17206) [FIX] SAML Idp Initiated Logout Error (#17324) [NEW] Better Push and Email Notification logic (#17357) [NEW] Error page when browser is not supported (#17372) [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141) [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488) [IMPROVE] Filter markdown in notifications (#9995) [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056) Remove set as alias setting (#16343) [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858) [NEW] Add ability to set tags in the Omnichannel room closing dialog (#17254) [FIX] Show active admin and user account menu item (#17047) [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335) [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331) [FIX] Remove properties from users.info response (#17238) Bump version to 3.1.1 ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.