[NEW] Federation event for when users left rooms #17091
Conversation
ndroo
left a comment
There was a problem hiding this comment.
This looks like it addresses a bug I've been experiencing related to room invites not working. I'll test and reply back.
ndroo
left a comment
There was a problem hiding this comment.
This corrected the issue i had around federated room invites not working. Thank you!
|
hey @1rV1N-git! Thanks for your contributions! I will check #16879 and add a fix on this PR as well. EDIT: is is fixed, I just added the event generation and handling. |
|
This is likely unrelated but I've found that when I use the mobile client the user being invited into a room bas a weird experience. The room doesnt appear in their list of channels until they click the notification, which unfortunately means if they dont action the notification they never actually make it into the room. I'm going to verify this today, i was looking at it around midnight after a long day and want to document the actual issue clearly. |
|
I merged all these changes into our test build, they all work really well. Thanks for contributing them. I'll let someone from RC review this, but just wanted to drop a thanks :) I'm going to look at contributing some other features i.e. having /invite work even when the user has not yet been included from a federation perspective |
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] 2FA not showing codes for Spanish translation (#17378) [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users (#17333) [NEW] Federation event for when users left rooms (#17091) [FIX] CSV Importer fails when there are no users to import (#16790) Import slack's mpims as direct rooms instead of private groups (#17206) [FIX] SAML Idp Initiated Logout Error (#17324) [NEW] Better Push and Email Notification logic (#17357) [NEW] Error page when browser is not supported (#17372) [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141) [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488) [IMPROVE] Filter markdown in notifications (#9995) [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056) Remove set as alias setting (#16343) [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858) [NEW] Add ability to set tags in the Omnichannel room closing dialog (#17254) [FIX] Show active admin and user account menu item (#17047) [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335) [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331) [FIX] Remove properties from users.info response (#17238) Bump version to 3.1.1 ...
Closes #16878
Closes #16861
Closes #16879