Skip to content

Method body replacement#141

Merged
Ocramius merged 6 commits intomasterfrom
monkey-patching-methods
Feb 19, 2016
Merged

Method body replacement#141
Ocramius merged 6 commits intomasterfrom
monkey-patching-methods

Conversation

@asgrim
Copy link
Copy Markdown
Member

@asgrim asgrim commented Oct 28, 2015

Solves part of #134 (ability to replace the statements within a function or method)

Note this requires PR #135 to be merged first, so do not merge please.

Also depends on jeremeamia/super_closure#70 (stable in 2.2.0+ now, which is used by our master now anyway)

@asgrim asgrim self-assigned this Oct 28, 2015
@asgrim asgrim added this to the 1.0.0 milestone Oct 28, 2015
asgrim
asgrim reviewed Oct 28, 2015
View reviewed changes
composer.json Outdated
Copy link
Copy Markdown
Member Author

@asgrim asgrim Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs replacing before merge

Copy link
Copy Markdown
Member Author

@asgrim asgrim Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the version, not the whole dependency)

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Oct 30, 2015

Note: I would not merge this until we first have a stable (tagged) API with the read-only part of better-reflection

@asgrim asgrim modified the milestones: 1.1.0, 1.0.0 Nov 1, 2015
@asgrim
Copy link
Copy Markdown
Member Author

asgrim commented Nov 1, 2015

@Ocramius agreed. I just created 1.1.0 milestone for future releases

@asgrim asgrim force-pushed the monkey-patching-methods branch 2 times, most recently from 0ff473f to 72be51f Compare November 5, 2015 15:29
@asgrim
Copy link
Copy Markdown
Member Author

asgrim commented Nov 26, 2015

@asgrim worth rebasing and looking at comments after #151 is merged

@asgrim asgrim force-pushed the monkey-patching-methods branch 2 times, most recently from e3b02b7 to 74a39de Compare February 6, 2016 00:11
@asgrim asgrim changed the title [DO NOT MERGE] Method body replacement [WIP] Method body replacement Feb 6, 2016
@asgrim asgrim force-pushed the monkey-patching-methods branch from e79eadd to 15fa288 Compare February 7, 2016 13:25
@asgrim asgrim force-pushed the monkey-patching-methods branch 2 times, most recently from db6dc72 to 3a738f4 Compare February 19, 2016 11:56
@asgrim asgrim changed the title [WIP] Method body replacement Method body replacement Feb 19, 2016
@asgrim asgrim assigned Ocramius and unassigned asgrim Feb 19, 2016
@asgrim asgrim force-pushed the monkey-patching-methods branch from 3a738f4 to 8120e79 Compare February 19, 2016 12:48
Ocramius added a commit that referenced this pull request Feb 19, 2016
@Ocramius
Merge pull request #141 from Roave/monkey-patching-methods
8ec5906 
Method body replacement
@Ocramius Ocramius merged commit 8ec5906 into master Feb 19, 2016
@Ocramius Ocramius deleted the monkey-patching-methods branch February 19, 2016 13:32
@Ocramius Ocramius mentioned this pull request Feb 22, 2016
Merged
@asgrim asgrim mentioned this pull request Mar 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

feature request

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asgrim @Ocramius