Conversation
…erate on node type
aeaf011 to
5c1a60f
Compare
There was a problem hiding this comment.
Does the fact that a closure source locator is used limit reflection of type hints?
As in:
$c = function (Foo $foo) : Bar {}
Can I get reflection for $foo and for the return parameter even if a ClosureSourceLocator was used?
…s in ReflectionFunctionAbstract
There was a problem hiding this comment.
Should probably bubble up as an exception in our own namespace?
There was a problem hiding this comment.
Is there much benefit? The exception message is very clear, we'd only be wrapping it anyway - plus if this issue goes away, then this test will start failing anyway (alerting us that we can change this expectation...)
There was a problem hiding this comment.
That is true, but making an exception from a different namespace bubble up (for a known case) will cause the consumers to type-hint against the third-party lib (without importing it manually, which is a mistake), and we would have to document all @throws with third-party lib classes (again bad)
|
Dang, totally forgot to merge this, sorry :| |
|
Don't worry, I did it :D |
Handles issue #37 by adding ability to reflect on anonymous functions / closures.