Don't log App Store / StoreKit messages when using a Test Store API key by rickvdl · Pull Request #6906 · RevenueCat/purchases-ios

rickvdl · 2026-06-04T08:48:46Z

When using a test store API key we were still making some StoreKit calls and logging it’s errors (which is quite likely when using test store, since chances are high that the product’s haven’t been configured on the ASC / StoreKit config side yet) .

This was confusing, as you’d use test store in cases where you actually don’t want to use StoreKit.

Changes made

When using test store we’re no longer looking at the StoreKit Transaction updates on configure and are no longer listening for transaction updates
Updated a bunch of info/warning/error logging strings to have variants that don’t mention the App Store / ASC / StoreKit when using test store

Note

Medium Risk
Touches configure-time transaction fetching and customer-info paths plus widespread offering error messages; behavior change is intentional for Test Store but affects core purchase/offering flows.

Overview
Test Store API keys now avoid StoreKit transaction plumbing and surface configuration messages that match how that mode works.

StoreKit bypass: Purchases wires in SimulatedStoreTransactionFetcher instead of StoreKit2TransactionFetcher when the key is simulated. That fetcher always returns empty/nil transaction data (with a warning if a receipt fetch is attempted). PurchasesOrchestrator skips starting StoreKit.Transaction.updates listening and SK2 purchase-intent listening in simulated-store mode. Customer info still goes through the backend when there are no unfinished transactions (covered by new tests).

Logging: Configure, offering, and purchase log strings now take apiKeyValidationResult and branch copy for Test Store vs App Store / legacy vs other platforms—e.g. simulator setup no longer tells you to use a StoreKit Configuration file when using a Test Store key; offering empty/missing-product errors point at RevenueCat Test Store config instead of App Store Connect; the iOS 18.4 simulator workaround text is suppressed for Test Store.

Offerings: OfferingsFactory holds SystemInfo so empty-offering warnings use the same API-key-aware messages. OfferingsManager passes validation result through empty-product and missing-product errors.

Tests: New/updated unit tests for string variants, transaction fetcher, orchestrator SK2 behavior, and customer info with simulated store.

^{Reviewed by Cursor Bugbot for commit 7d87d1f. Bugbot is set up for automated code reviews on this repo. Configure here.}

rickvdl · 2026-06-04T09:09:51Z

+                "RevenueCat dashboard could be fetched from App Store Connect (or the StoreKit Configuration " +
+                "file if one is being used). \nMore information: https://rev.cat/why-are-offerings-empty"
+            case .simulatedStore:
+                return "There's a problem with your configuration. None of the Test Store products registered in " +


This shouldn’t happen in theory, but updated it just in case

rickvdl · 2026-06-04T09:59:55Z

@RCGitBot please test

tonidero

Nice one! This is great, thank you!!

tonidero · 2026-06-04T10:11:45Z

+
+        // The Simulated Store ("Test Store") never touches StoreKit, so skip reading
+        // StoreKit transactions and the storefront and fetch CustomerInfo from the backend directly.
+        if self.systemInfo.isSimulatedStoreAPIKey {


Hmm I'm wondering if we would like to create a SimulatedStoreTransactionFetcher that can be used in these scenarios, and can be used to simulate cases when using the store down the line. As an initial version it could always return no transactions...

But this is just an idea and wouldn't add any value right now. Since this is probably easier for now, I think this is ok :)

Good point! I did think about that, but didn’t end up implementing it. But I do agree that it’s a bit cleaner, so I made the change now :)

tonidero · 2026-06-04T10:13:34Z

+                    "\nThere is a problem with your configuration in App Store Connect. " +
+                    "\nMore info here: https://errors.rev.cat/configuring-products"
+            case .simulatedStore:
+                return "Could not find products with identifiers: \(identifiers)." +


I "believe" this shouldn't really ever happen... But it's ok to add it :)

tonidero · 2026-06-04T10:14:38Z

@@ -2338,6 +2338,11 @@ extension PurchasesOrchestrator {

    private func setSK2DelegateAndStartListening() async {
        await storeKit2TransactionListener.set(delegate: self)


Just to make sure. Is it fine to still set the delegate?

I think so since we didn’t start listening. But you’re right in the sense that it isn’t guaranteed, so I changed it to not setting the delegate at all

rickvdl · 2026-06-04T12:48:15Z

@RCGitBot please test

rickvdl · 2026-06-04T12:55:05Z

@RCGitBot please test

tonidero

🚢

tonidero · 2026-06-04T14:18:52Z

+    }
+
+    /// Unused in Simulated Store mode: no transactions are ever posted, so no receipt is fetched.
+    /// Returns an empty receipt to satisfy the protocol.


Could be worth logging something in this case just in case?

Added some logging for this

…pp Store logs

…ing App Store

…nResult enum

…rors

…g apiKeyValidationResult

…stener in Test Store mode

rickvdl · 2026-06-05T05:54:15Z

@RCGitBot please test

ajpallares · 2026-06-05T07:07:16Z

Great one! Thanks for doing this!

… Store is used (RevenueCat#3538) Android counterpart for RevenueCat/purchases-ios#6906, making offering product loading errors test-store aware. This prevents these errors from pointing developers to the Play Store when Test Store is used. These errors should rarely happen (if at all) but figured it was good to add for consistency.  --- > [!NOTE] > **Low Risk** > String-only branching on configured store for logs and configuration errors; behavior unchanged aside from messaging, with unit test coverage. > > **Overview** > When the SDK is configured for **Test Store**, offering/product configuration errors no longer tell developers to fix things in the **Play Store**. The change threads `appConfig.store` into offerings building and picks **Test Store–specific** copy from `OfferingStrings` instead of the Play Store templates. > > **`OfferingsFactory`** now uses Test Store strings for missing-product warnings and for the configuration error when no dashboard products resolve. **`OfferingParser.createOfferings`** gains a `configuredStore` parameter (default Play Store) and routes empty-offering warnings through a small helper that selects the right template. New constants cover cannot-find-product, products-not-found, and empty-offering cases for Test Store (RevenueCat dashboard wording). Tests assert string content and that Test Store flows return the Test Store configuration error without mentioning Play Store. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4a1b9c3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

rickvdl added the pr:fix A bug fix label Jun 4, 2026

rickvdl force-pushed the fix-simulated-store-appstore-logging branch from f1b01ab to eb4ac57 Compare June 4, 2026 08:50

rickvdl commented Jun 4, 2026

View reviewed changes

rickvdl marked this pull request as ready for review June 4, 2026 10:05

rickvdl requested review from a team as code owners June 4, 2026 10:05

tonidero approved these changes Jun 4, 2026

View reviewed changes

rickvdl force-pushed the fix-simulated-store-appstore-logging branch from 4b81b79 to c0edc3f Compare June 4, 2026 12:48

rickvdl mentioned this pull request Jun 4, 2026

fix(test-store): don’t mention Play Store in error logs when the Test Store is used RevenueCat/purchases-android#3538

Merged

tonidero approved these changes Jun 4, 2026

View reviewed changes

rickvdl added 12 commits June 5, 2026 07:24

fix: Skip StoreKit calls in Simulated Store mode to avoid confusing A…

04701dc

…pp Store logs

fix: Make empty-offering warning Test Store aware instead of referenc…

425d31e

…ing App Store

fix: Make simulator StoreKit-config warning Test Store aware

74a87f6

fix: Make offering product-configuration errors Test Store aware

7f64f31

refactor: Use positive Test Store check and switch on APIKeyValidatio…

0ab2952

…nResult enum

fix: Drop iOS 18.4 simulator note from non-App Store product-fetch er…

57415f9

…rors

refactor: Inject SystemInfo into OfferingsFactory instead of threadin…

23dcee6

…g apiKeyValidationResult

refactor: Use SimulatedStoreTransactionFetcher and skip wiring SK2 li…

c9a3a61

…stener in Test Store mode

Disable purchase intent listener for Test Store

410436a

Log unexpected Test Store receipt fetches

1af660b

fix: Trim simulator Test Store log message

afee4f6

fix: Disable file_length lint for PurchaseStrings

7d87d1f

rickvdl force-pushed the fix-simulated-store-appstore-logging branch from c98a641 to 7d87d1f Compare June 5, 2026 05:26

rickvdl merged commit 7144994 into main Jun 5, 2026
43 checks passed

rickvdl deleted the fix-simulated-store-appstore-logging branch June 5, 2026 06:20

RCGitBot mentioned this pull request Jun 8, 2026

[AUTOMATIC] Release/5.78.0 #6954

Merged

		@@ -2338,6 +2338,11 @@ extension PurchasesOrchestrator {

		private func setSK2DelegateAndStartListening() async {
		await storeKit2TransactionListener.set(delegate: self)

Uh oh!

Conversation

rickvdl commented Jun 4, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes made

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickvdl commented Jun 4, 2026

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickvdl commented Jun 4, 2026

Uh oh!

rickvdl commented Jun 4, 2026

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickvdl commented Jun 5, 2026

Uh oh!

Uh oh!

ajpallares commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rickvdl commented Jun 4, 2026 •

edited by cursor Bot

Loading