fix(test-store): don’t mention Play Store in error logs when the Test Store is used#3538
Merged
Merged
Conversation
tonidero
approved these changes
Jun 4, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Indeed... I would say the only scenarios where this would happen are if there are no test store products configured at all, or for some reason, the requests to fetch those fail... But yeah, I think it doesn't hurt.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3538 +/- ##
==========================================
- Coverage 80.13% 80.11% -0.02%
==========================================
Files 371 371
Lines 15155 15166 +11
Branches 2096 2100 +4
==========================================
+ Hits 12144 12150 +6
- Misses 2161 2166 +5
Partials 850 850 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android counterpart for RevenueCat/purchases-ios#6906, making offering product loading errors test-store aware. This prevents these errors from pointing developers to the Play Store when Test Store is used.
These errors should rarely happen (if at all) but figured it was good to add for consistency.
Note
Low Risk
String-only branching on configured store for logs and configuration errors; behavior unchanged aside from messaging, with unit test coverage.
Overview
When the SDK is configured for Test Store, offering/product configuration errors no longer tell developers to fix things in the Play Store. The change threads
appConfig.storeinto offerings building and picks Test Store–specific copy fromOfferingStringsinstead of the Play Store templates.OfferingsFactorynow uses Test Store strings for missing-product warnings and for the configuration error when no dashboard products resolve.OfferingParser.createOfferingsgains aconfiguredStoreparameter (default Play Store) and routes empty-offering warnings through a small helper that selects the right template. New constants cover cannot-find-product, products-not-found, and empty-offering cases for Test Store (RevenueCat dashboard wording). Tests assert string content and that Test Store flows return the Test Store configuration error without mentioning Play Store.Reviewed by Cursor Bugbot for commit 4a1b9c3. Bugbot is set up for automated code reviews on this repo. Configure here.