Add RequestSizeCalculation.swift to RevenueCat.xcodeproj#6713
Merged
ajpallares merged 1 commit intoApr 30, 2026
Merged
Conversation
The file was added in #6694 but not registered in the hand-maintained RevenueCat.xcodeproj used by the XCFramework build, breaking release-checks. Made-with: Cursor
rickvdl
approved these changes
Apr 30, 2026
ajpallares
added a commit
that referenced
this pull request
Apr 30, 2026
…)" This reverts commit 0dbac51.
ajpallares
added a commit
that referenced
this pull request
Apr 30, 2026
)" This reverts commit ef64763.
ajpallares
added a commit
that referenced
this pull request
Apr 30, 2026
The Dangerfile already detects Swift files that are added (or removed) on disk but not registered in the hand-maintained `RevenueCat.xcodeproj`. Until now, that mismatch was reported as a warning, so PRs could merge in a state that breaks the xcframework build (see #6713/#6694). Promote the existing `warn` to `fail` so the PR's required Danger check blocks merge until the project file is in sync. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RequestSizeCalculation.swiftwas added in #6694 but not registered in theRevenueCat.xcodeproj, which is used by the XCFramework build. This broke therelease-checksCI job.Description
Adds the file reference, build file, group entry, and Sources phase entry for
RequestSizeCalculation.swiftso the XCFramework build picks it up.Made with Cursor
Note
Low Risk
Project-file only change to include an already-existing source file in the Xcode build; low functional risk, but impacts XCFramework/CI build correctness.
Overview
Fixes the hand-maintained
RevenueCat.xcodeprojso XCFramework/release CI builds compile by addingRequestSizeCalculation.swiftto the project (file reference, group membership, and Sources build phase).Also includes minor reordering/relocation of a few existing test file entries in the project file with no intended behavior change.
Reviewed by Cursor Bugbot for commit f4e04af. Bugbot is set up for automated code reviews on this repo. Configure here.