Fail PRs when Swift files are missing from RevenueCat.xcodeproj#6716
Merged
Conversation
The Dangerfile already detects Swift files that are added (or removed) on disk but not registered in the hand-maintained `RevenueCat.xcodeproj`. Until now, that mismatch was reported as a warning, so PRs could merge in a state that breaks the xcframework build (see #6713/#6694). Promote the existing `warn` to `fail` so the PR's required Danger check blocks merge until the project file is in sync. Made-with: Cursor
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Dangerfile already detects Swift files that are added (or removed) on disk but not registered in the hand-maintained
RevenueCat.xcodeproj. Until now this mismatch was reported only as a warning, so PRs could still merge in a state that breaks the xcframework build (see #6713 / #6694).Description
Promote the existing
warntofailincheck_swift_files_in_projectso the Danger check blocks merge until the project file is back in sync. No other behaviour changes — the same files are detected and the same remediation message is shown.This obsoletes the heavier
xcframework-build-smokeCI job approach in #6715 for this specific failure mode: Danger runs early, costs almost nothing, and pinpoints the exact missing files with a clear fix-up message.Made with Cursor
Note
Low Risk
Low risk: this only tightens CI/Danger enforcement by turning an existing warning into a failure, with no product/runtime behavior changes.
Overview
Blocks merges when
RevenueCat.xcodeprojis out of sync with Swift files on disk.Promotes the existing
check_swift_files_in_projectDanger check fromwarntofail, so added Swift files missing from the project (or deleted files still referenced) now fail the PR instead of merely warning.Reviewed by Cursor Bugbot for commit a99deb4. Bugbot is set up for automated code reviews on this repo. Configure here.