Generating new test snapshots for feat/paywall-events-placement-targeting - ios-18#6498
Merged
Conversation
Generated by 🚫 Danger |
rickvdl
approved these changes
Mar 20, 2026
545e6f0
into
feat/paywall-events-placement-targeting
3 of 13 checks passed
📸 Snapshot TestBase build not foundNo build was found for the base commit e6cd64c. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
rickvdl
pushed a commit
that referenced
this pull request
Mar 20, 2026
rickvdl
pushed a commit
that referenced
this pull request
Mar 23, 2026
rickvdl
pushed a commit
that referenced
this pull request
Apr 16, 2026
rickvdl
pushed a commit
that referenced
this pull request
Apr 16, 2026
rickvdl
pushed a commit
that referenced
this pull request
Apr 20, 2026
rickvdl
pushed a commit
that referenced
this pull request
Apr 28, 2026
rickvdl
added a commit
that referenced
this pull request
Apr 28, 2026
* Add placement and targeting rule to paywall events Include presentedOfferingContext (placementIdentifier, targetingRevision, targetingRuleId) in paywall event serialization so the backend can calculate conversion rates per placement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix SwiftLint nesting violation in PresentedOfferingContextData Move PresentedOfferingContextData from nested struct inside FeatureEventsRequest.PaywallEvent to an extension to avoid exceeding the 1-level nesting limit. * Add failable init to PresentedOfferingContextData Move nil-checking logic into a failable initializer on PresentedOfferingContextData, simplifying the call site. * [skip ci] Generating new test snapshots (#6494) * [skip ci] Generating new test snapshots (#6495) * [skip ci] Generating new test snapshots (#6500) * [skip ci] Generating new test snapshots (#6499) * [skip ci] Generating new test snapshots (#6498) * [skip ci] Generating new test snapshots (#6497) * [skip ci] Generating new test snapshots (#6496) * Simplify PaywallEvent.Data init to accept PresentedOfferingContext directly Replace three separate placement/targeting parameters with a single PresentedOfferingContext? parameter in the internal init, removing duplicated property extraction across all four public initializers. Also simplify withPurchaseInfo to use var copy. * Add partial context and round-trip tests for paywall events - Add round-trip test with placement/targeting through serialize → deserialize → backend event pipeline - Add placement-only test (no targeting) - Add targeting-only test (no placement) * Add missing iOS15 snapshot for placement/targeting test * Add backward compat test for old stored events without placement/targeting Verify that events serialized before placement/targeting fields were added still deserialize correctly and produce nil presentedOfferingContext. * Remove unnecessary backward compat test --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com> Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @rickvdl for feat/paywall-events-placement-targeting
Note
Low Risk
Adds/updates a unit test snapshot only; no production code paths change, so risk is limited to potential snapshot brittleness across environments.
Overview
Adds a new iOS 18 unit-test snapshot for
BackendPaywallEventTests.testPostPaywallEventsWithPlacementAndTargeting, capturing the expectedPOST /v1/eventspayload includingpresented_offering_contextfields (placement_identifier,targeting_revision,targeting_rule_id) and request headers.Written by Cursor Bugbot for commit 8945944. This will update automatically on new commits. Configure here.