Add placement and targeting rule to paywall events by dpannasch · Pull Request #6476 · RevenueCat/purchases-ios

dpannasch · 2026-03-17T16:56:54Z

Include presentedOfferingContext (placementIdentifier, targetingRevision, targetingRuleId) in paywall event serialization so that events & charts can utilize those dimensions.

Checklist

If applicable, unit tests
If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Description

Note

Medium Risk
Changes the JSON schema sent to the paywalls events endpoint by adding a new optional nested object, which could affect backend parsing/analytics if not handled, though the fields are additive and nil-safe.

Overview
Paywall feature events now include an optional presented_offering_context payload (placement + targeting rule metadata) when serialized and posted to the paywalls events backend.

This threads PresentedOfferingContext data from Offering/Package into PaywallEvent.Data, encodes it via a new PresentedOfferingContextData wrapper that omits the object when all fields are nil, and updates withPurchaseInfo to preserve these new fields. Unit + snapshot tests were added to cover placement-only, targeting-only, and combined cases, including end-to-end backend request snapshots across platforms.

^{Reviewed by Cursor Bugbot for commit 0ad31b9. Bugbot is set up for automated code reviews on this repo. Configure here.}

emerge-tools · 2026-03-20T14:36:25Z

📸 Snapshot Test

327 unchanged

Name	Added	Removed	Modified	Renamed	Unchanged	Errored	Approval
PaywallsTester V1 swift-snapshot-testing com.revenuecat.PaywallsTester.v1-snapshots	0	0	0	0	63	0	N/A
RevenueCat com.revenuecat.PaywallsTester	0	0	0	0	264	0	N/A

🛸 Powered by Emerge Tools

rickvdl · 2026-03-20T15:35:32Z

@RCGitBot please test

emerge-tools · 2026-03-20T15:58:54Z

4 builds increased size

Name	Version	Download	Change	Install	Change	Approval
RevenueCat com.revenuecat.PaywallsTester	1.0 (1)	17.8 MB	⬆️ 16.4 kB (0.09%)	64.1 MB	⬆️ 113.0 kB (0.18%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.local-source	1.0 (1)	4.0 MB	⬆️ 5.1 kB (0.13%)	12.2 MB	⬆️ 23.2 kB (0.19%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.cocoapods	1.0 (1)	6.1 MB	⬆️ 7.0 kB (0.11%)	26.9 MB	⬆️ 35.7 kB (0.13%)	⏳ Needs approval
BinarySizeTest com.revenuecat.binary-size-test.spm	1.0 (1)	4.1 MB	⬆️ 6.9 kB (0.17%)	10.6 MB	⬆️ 23.2 kB (0.22%)	N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 113.0 kB (0.18%)
Total download size change: ⬆️ 16.4 kB (0.09%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 17.3 kB
RevenueCat.InternalAPI.InternalAPI	⬆️ 3.3 kB
RevenueCatUI.PaywallViewController.PaywallViewController	⬆️ 2.9 kB
Code Signature	⬆️ 2.7 kB
RCPurchases.Objc Metadata	⬆️ 2.7 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 23.2 kB (0.19%)
Total download size change: ⬆️ 5.1 kB (0.13%)

Largest size changes

Item	Install Size Change
RevenueCat.PurchasedTransactionDataEncodedWrapper.value witness	⬆️ 3.8 kB
RevenueCat.LocalTransactionMetadata.value witness	⬆️ 3.5 kB
RevenueCat.PaywallEvent.value witness	⬆️ 2.7 kB
RevenueCat.PurchasedTransactionData.value witness	⬆️ 2.5 kB
RevenueCat.PurchasesOrchestrator.CachedPurchaseContext.value witn...	⬆️ 2.5 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 35.7 kB (0.13%)
Total download size change: ⬆️ 7.0 kB (0.11%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 10.3 kB
RevenueCat.PurchasedTransactionDataEncodedWrapper.value witness	⬆️ 3.8 kB
RevenueCat.LocalTransactionMetadata.value witness	⬆️ 3.5 kB
RevenueCat.PaywallEvent.value witness	⬆️ 2.7 kB
RevenueCat.PurchasedTransactionData.value witness	⬆️ 2.5 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 23.2 kB (0.22%)
Total download size change: ⬆️ 6.9 kB (0.17%)

Largest size changes

Item	Install Size Change
RevenueCat.PurchasedTransactionDataEncodedWrapper.value witness	⬆️ 3.8 kB
RevenueCat.LocalTransactionMetadata.value witness	⬆️ 3.5 kB
RevenueCat.PaywallEvent.value witness	⬆️ 2.7 kB
RevenueCat.PurchasedTransactionData.value witness	⬆️ 2.5 kB
RevenueCat.PurchasesOrchestrator.CachedPurchaseContext.value witn...	⬆️ 2.5 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

rickvdl · 2026-03-23T07:42:16Z

@RCGitBot please test

rickvdl · 2026-03-23T10:47:17Z

@RCGitBot please test

tonidero

Looks great!

ajpallares

Looks great!

ajpallares · 2026-03-24T07:27:15Z

+        var copy = self
+        copy.packageId = packageId
+        copy.productId = productId
+        copy.errorCode = errorCode
+        copy.errorMessage = errorMessage
+        return copy


rickvdl · 2026-04-16T13:41:30Z

@RCGitBot please test

rickvdl · 2026-04-20T07:43:10Z

@RCGitBot please test

rickvdl · 2026-04-20T07:43:32Z

@RCGitBot please test

Include presentedOfferingContext (placementIdentifier, targetingRevision, targetingRuleId) in paywall event serialization so the backend can calculate conversion rates per placement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Move PresentedOfferingContextData from nested struct inside FeatureEventsRequest.PaywallEvent to an extension to avoid exceeding the 1-level nesting limit.

Move nil-checking logic into a failable initializer on PresentedOfferingContextData, simplifying the call site.

…rectly Replace three separate placement/targeting parameters with a single PresentedOfferingContext? parameter in the internal init, removing duplicated property extraction across all four public initializers. Also simplify withPurchaseInfo to use var copy.

- Add round-trip test with placement/targeting through serialize → deserialize → backend event pipeline - Add placement-only test (no targeting) - Add targeting-only test (no placement)

…eting Verify that events serialized before placement/targeting fields were added still deserialize correctly and produce nil presentedOfferingContext.

rickvdl · 2026-04-28T10:30:34Z

@RCGitBot please test

## Summary - Include `placement_identifier`, `targeting_revision`, and `targeting_rule_id` in paywall events under a `presented_offering_context` nested object - Field is omitted when no placement or targeting data exists - Consistent with iOS and Android implementations ## Related PRs - iOS: RevenueCat/purchases-ios#6476 - Android: RevenueCat/purchases-android#3253 ## Test plan - [x] Unit tests for all context permutations (full, placement-only, targeting-only, none, empty string) - [x] JSON round-trip serialization tests - [x] Integration test verifying context flows from offering to event payload - [x] Manual testing with targeting rules and placements in demo app

rickvdl added the pr:feat A new feature label Mar 20, 2026

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from df2f4e1 to b076fe1 Compare March 20, 2026 14:33

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from 78c72b4 to f35f2bd Compare March 20, 2026 15:48

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from f35f2bd to 7b9caf4 Compare March 23, 2026 08:08

rickvdl marked this pull request as ready for review March 23, 2026 12:27

rickvdl requested a review from a team as a code owner March 23, 2026 12:27

rickvdl changed the title ~~DRAFT: Add placement and targeting rule to paywall events~~ Add placement and targeting rule to paywall events Mar 23, 2026

tonidero approved these changes Mar 23, 2026

View reviewed changes

Comment thread Sources/Paywalls/Events/Networking/EventsRequest+Paywall.swift

ajpallares approved these changes Mar 24, 2026

View reviewed changes

rickvdl mentioned this pull request Mar 24, 2026

Add presented offering context to paywall events RevenueCat/purchases-js#818

Merged

4 tasks

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from e41d6de to 4e979b8 Compare April 16, 2026 13:28

rickvdl requested a review from a team as a code owner April 16, 2026 13:28

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from 4e979b8 to edf9e61 Compare April 16, 2026 13:41

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from edf9e61 to 5e39a87 Compare April 20, 2026 07:43

dpannasch and others added 8 commits April 28, 2026 12:20

Fix SwiftLint nesting violation in PresentedOfferingContextData

5807e3f

Move PresentedOfferingContextData from nested struct inside FeatureEventsRequest.PaywallEvent to an extension to avoid exceeding the 1-level nesting limit.

Add failable init to PresentedOfferingContextData

25d6b06

Move nil-checking logic into a failable initializer on PresentedOfferingContextData, simplifying the call site.

[skip ci] Generating new test snapshots (#6494)

fb945fc

[skip ci] Generating new test snapshots (#6495)

39b4504

[skip ci] Generating new test snapshots (#6500)

2cd3c92

[skip ci] Generating new test snapshots (#6499)

6f3e883

[skip ci] Generating new test snapshots (#6498)

6f92ff5

RCGitBot and others added 7 commits April 28, 2026 12:20

[skip ci] Generating new test snapshots (#6497)

e1cf9b2

[skip ci] Generating new test snapshots (#6496)

819c155

Add partial context and round-trip tests for paywall events

06f04f3

- Add round-trip test with placement/targeting through serialize → deserialize → backend event pipeline - Add placement-only test (no targeting) - Add targeting-only test (no placement)

Add missing iOS15 snapshot for placement/targeting test

f338db5

Add backward compat test for old stored events without placement/targ…

37d6251

…eting Verify that events serialized before placement/targeting fields were added still deserialize correctly and produce nil presentedOfferingContext.

Remove unnecessary backward compat test

0ad31b9

rickvdl force-pushed the feat/paywall-events-placement-targeting branch from 5e39a87 to 0ad31b9 Compare April 28, 2026 10:21

rickvdl merged commit 658d12d into main Apr 28, 2026
41 of 42 checks passed

rickvdl deleted the feat/paywall-events-placement-targeting branch April 28, 2026 11:43

rickvdl mentioned this pull request Apr 28, 2026

Add presented offering context to custom paywall events #6707

Merged

This was referenced Apr 30, 2026

[AUTOMATIC] Release/5.70.0 #6712

Closed

[AUTOMATIC] Release/5.70.0 #6714

Merged

Uh oh!

Conversation

dpannasch commented Mar 17, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Motivation

Description

Uh oh!

emerge-tools Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

327 unchanged

Uh oh!

rickvdl commented Mar 20, 2026

Uh oh!

emerge-tools Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4 builds increased size

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.local-source

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.cocoapods

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.spm

Uh oh!

rickvdl commented Mar 23, 2026

Uh oh!

rickvdl commented Mar 23, 2026

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

ajpallares Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

rickvdl commented Apr 16, 2026

Uh oh!

rickvdl commented Apr 20, 2026

Uh oh!

rickvdl commented Apr 20, 2026

Uh oh!

rickvdl commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dpannasch commented Mar 17, 2026 •

edited by cursor Bot

Loading

emerge-tools Bot commented Mar 20, 2026 •

edited

Loading

emerge-tools Bot commented Mar 20, 2026 •

edited

Loading

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm