Remove networkName from AdFailedToLoad event#6208
Merged
Merged
Conversation
When an ad fails to load, multiple networks may have been involved in trying to fulfill the request. Attributing the failure to a single network is not meaningful. This is a breaking change for the experimental ad tracking API.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Restructure internal protocol hierarchy: - AdEventData no longer includes networkName (base protocol) - AdImpressionEventData includes networkName (for impression events) - Add AdEvent.networkName computed property for request building - Update AdEventsRequest to use adEvent.networkName
rickvdl
approved these changes
Feb 5, 2026
polmiro
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Feb 6, 2026
…ad events (#1461) ## Summary - Remove `networkName` from `trackAdFailedToLoad` in both Android and iOS — when an ad fails to load, multiple networks may have been involved, so attributing the failure to a single network is not meaningful - Make `networkName` nullable/optional in `trackAdDisplayed`, `trackAdOpened`, `trackAdRevenue`, and `trackAdLoaded` — ad SDKs can return null for the network name - Bump iOS SDK `5.57.1` → `5.57.2` and Android SDK `9.20.1` → `9.20.2` These are breaking changes for the experimental ad tracking API. **Related PRs:** - RevenueCat/purchases-android#3074 - RevenueCat/purchases-ios#6208 - RevenueCat/purchases-android#3076 - RevenueCat/purchases-ios#6229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkNamefield fromAdFailedToLoadclassnetworkNameoptional inAdEventDataprotocol andAdEventsRequestWhen an ad fails to load, multiple networks may have been involved in trying to fulfill the request. Attributing the failure to a single network is not meaningful.
This is a breaking change for the experimental ad tracking API (
@_spi(Experimental)).