Make networkName nullable in ad event data types#3076
Merged
Conversation
Allow null for networkName in AdLoadedData, AdDisplayedData, AdOpenedData, and AdRevenueData. Ad SDKs like AdMob may return null when the network name is unknown, so developers no longer need to use arbitrary fallbacks.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 342 342
Lines 13680 13680
Branches 1841 1841
=======================================
Hits 10833 10833
Misses 2088 2088
Partials 759 759 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
**This is an automatic release.** ## RevenueCatUI SDK ### Customer Center #### 🐞 Bugfixes * CC-628: Refresh Customer Center UI after subscription cancellation (#3061) via Facundo Menzella (@facumenzella) ### Paywallv2 #### 🐞 Bugfixes * Improve carousel performance with videos (#3070) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Make networkName nullable in ad event data types (#3076) via Pol Miro (@polmiro) * Remove networkName from AdFailedToLoad event (#3074) via Pol Miro (@polmiro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
polmiro
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Feb 6, 2026
…ad events (#1461) ## Summary - Remove `networkName` from `trackAdFailedToLoad` in both Android and iOS — when an ad fails to load, multiple networks may have been involved, so attributing the failure to a single network is not meaningful - Make `networkName` nullable/optional in `trackAdDisplayed`, `trackAdOpened`, `trackAdRevenue`, and `trackAdLoaded` — ad SDKs can return null for the network name - Bump iOS SDK `5.57.1` → `5.57.2` and Android SDK `9.20.1` → `9.20.2` These are breaking changes for the experimental ad tracking API. **Related PRs:** - RevenueCat/purchases-android#3074 - RevenueCat/purchases-ios#6208 - RevenueCat/purchases-android#3076 - RevenueCat/purchases-ios#6229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkNamefromStringtoString?inAdLoadedData,AdDisplayedData,AdOpenedData, andAdRevenueDataAdEventsealed interface implementations accordinglyMotivation
Ad SDKs like AdMob can return null for network name (e.g.,
responseInfo?.mediationAdapterClassName). Previously, developers had to use arbitrary fallback values like"Google AdMob"or empty string"", which was misleading in analytics.Test plan