Mark methods with StaticString for appUserID as deprecated#3739
Merged
Conversation
b94ff3e to
648532a
Compare
MarkVillacampa
commented
Feb 29, 2024
| @available(*, deprecated, message: """ | ||
| The appUserID passed to logIn is a constant string known at compile time. | ||
| This is likely a programmer error. This ID is used to identify the current user. | ||
| See https://docs.revenuecat.com/docs/user-ids for more information. |
Member
Author
There was a problem hiding this comment.
I wish there was a way to not repeat these strings but I have not found one :/
Member
There was a problem hiding this comment.
what was the behavior before this? After this, it will add a warning right?
Member
Author
There was a problem hiding this comment.
Before this, we were only logging a warning int he console. Now, it will show a compilation warning in the IDE.
aboedo
approved these changes
Feb 29, 2024
This was referenced Mar 4, 2024
joshdholtz
added a commit
that referenced
this pull request
Mar 5, 2024
**This is an automatic release.** ### New Features * Paywalls: add `updateWithDisplayCloseButton` to `PaywallViewController` (#3708) via Cesar de la Vega (@vegaro) * New `syncAttributesAndOfferingsIfNeeded` method (#3709) via Burdock (@lburdock) * Add targeting to `PresentedOfferingContext` (#3730) via Josh Holtz (@joshdholtz) * Add `currentOffering(forPlacement: String)` to `Offerings` (#3707) via Guido Torres (@guido732) * New `Package.presentedOfferingContext` (#3712) via Josh Holtz (@joshdholtz) ### Bugfixes * Mark methods with StaticString for appUserID as deprecated (#3739) via Mark Villacampa (@MarkVillacampa) ### Other Changes * [EXTERNAL] Spelling typo fix to comment (#3713) via @vdeaugustine (#3740) via Mark Villacampa (@MarkVillacampa) --------- Co-authored-by: Josh Holtz <me@joshholtz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried conditionally compiling the
availabilityattribute, and marking it asunavailableinRELEASEbuilds, but the compiler is smart enough to ignore the method and choose the disfavored overload in that case.I also tried conditionally compiling the return type in the same way, to cause a compilation error in
RELEASEbuilds, but the compiler is again smart enough to choose the disfavored overload.