Add targeting to PresentedOfferingContext#3730
Merged
Merged
Conversation
tonidero
approved these changes
Feb 28, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Left some comments but LGTM!
| } | ||
| } | ||
|
|
||
| internal final class Targeting: NSObject { |
Contributor
There was a problem hiding this comment.
Should this be a struct? (maybe not, not entirely sure if it needs to be an NSObject)
Member
Author
There was a problem hiding this comment.
It probably should 😅 Not sure why I did the extra work of making this an NSObject...
| offeringIdentifier: String, | ||
| placementIdentifier: String? | ||
| placementIdentifier: String?, | ||
| targetingContext: TargetingContext? |
Contributor
There was a problem hiding this comment.
I was going to say this could be a breaking change, but I believe the base change hasn't been merged yet, so it should be ok 👍
|
|
||
| desc "Run BackendIntegrationTests" | ||
| lane :backend_integration_tests do |options| | ||
| fetch_snapshots |
Contributor
There was a problem hiding this comment.
Hmm is this needed? The snapshot tests for paywalls should be independent of these test I thought?
Member
Author
There was a problem hiding this comment.
The CI tests keep failing on UI Snapshots tests are missing in the backend tests so this was my test to see if this fixed it 🤷♂️ Will remove it stops the flakey
04abfe4 to
3eb9898
Compare
Base automatically changed from
guido/fia-2856-rework-ios-add-getcurrentoffering-to-offerings
to
main
February 28, 2024 21:11
…g-context` - ios-13 (#3737) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
…g-context` - ios-14 (#3736) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
…g-context` - ios-12 (#3735) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
…g-context` - ios-16 (#3734) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
…g-context` - ios-17 (#3733) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
…g-context` - ios-15 (#3732) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
…g-context` - macos (#3731) Requested by @joshdholtz for [add-targeting-to-presented-offering-context](https://github.com/RevenueCat/purchases-ios/tree/add-targeting-to-presented-offering-context)
4e60748 to
05d4981
Compare
This was referenced Mar 4, 2024
joshdholtz
added a commit
that referenced
this pull request
Mar 5, 2024
**This is an automatic release.** ### New Features * Paywalls: add `updateWithDisplayCloseButton` to `PaywallViewController` (#3708) via Cesar de la Vega (@vegaro) * New `syncAttributesAndOfferingsIfNeeded` method (#3709) via Burdock (@lburdock) * Add targeting to `PresentedOfferingContext` (#3730) via Josh Holtz (@joshdholtz) * Add `currentOffering(forPlacement: String)` to `Offerings` (#3707) via Guido Torres (@guido732) * New `Package.presentedOfferingContext` (#3712) via Josh Holtz (@joshdholtz) ### Bugfixes * Mark methods with StaticString for appUserID as deprecated (#3739) via Mark Villacampa (@MarkVillacampa) ### Other Changes * [EXTERNAL] Spelling typo fix to comment (#3713) via @vdeaugustine (#3740) via Mark Villacampa (@MarkVillacampa) --------- Co-authored-by: Josh Holtz <me@joshholtz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Get more context with targeting information
Description
OfferingsOfferings.currentgetCurrentOffering(forPlacement: String)