Prepare next version: 4.33.0-SNAPSHOT#3598
Merged
Merged
Conversation
tonidero
approved these changes
Jan 25, 2024
2 tasks
facumenzella
added a commit
that referenced
this pull request
Jun 15, 2026
Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
facumenzella
added a commit
that referenced
this pull request
Jun 15, 2026
…low (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MonikaMateska
added a commit
that referenced
this pull request
Jun 16, 2026
* fix(paywalls): skip workflow fetch for offerings with no mapped workflow (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Rename PaywallComponentsData.state → stateDeclarations --------- Co-authored-by: Facundo Menzella <facumenzella@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MonikaMateska
pushed a commit
that referenced
this pull request
Jun 17, 2026
…low (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MonikaMateska
added a commit
that referenced
this pull request
Jun 17, 2026
* feat(RevenueCatUI): evaluate state conditions in the override resolver * fix(paywalls): skip workflow fetch for offerings with no mapped workflow (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(RevenueCatUI): broadcast paywall state snapshot via environment values * feat(RevenueCatUI): re-resolve component overrides from paywall state * feat(RevenueCatUI): publish Tabs selected state into the store * test(RevenueCatUI): add PaywallsTester sample for state-driven tabs * Use state declarations as decoding key * fix(paywalls): seed workflow state store with page declarations * Revert "fix(paywalls): seed workflow state store with page declarations" This reverts commit b555709. * fix(paywalls): stop stale state env from overriding workflow values * Use stateDeclarations wire key in state decoding tests * Revert Package.resolved to main --------- Co-authored-by: Facundo Menzella <facumenzella@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.