Fix legacy paywalls when workflows are enabled#3598
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
- Coverage 80.26% 80.26% -0.01%
==========================================
Files 378 378
Lines 15448 15449 +1
Branches 2143 2144 +1
==========================================
Hits 12400 12400
- Misses 2189 2190 +1
Partials 859 859 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9d544af to
43cfd46
Compare
8956487 to
8fd591a
Compare
…mapped ones When `DangerousSettings.useWorkflows` is enabled, the paywall is now served through the /workflows endpoint for every non-legacy paywall, detected via `offering.paywall`: - `offering.paywall != null` → legacy v1 paywall → render through the legacy path, no workflow fetch. This is the durable marker of a legacy paywall and survives the eventual removal of `paywallComponents`. - `offering.paywall == null` → workflow paywall → fetch from /workflows, using the mapped workflow id when known (aligns with the prefetch cache) and otherwise the offering id, which the backend lazily converts for paywalls not yet migrated. The previous gate keyed off the offeringId→workflowId map, which only contains explicitly-converted workflows. A V2 paywall not yet converted (absent from the map) fell through to the single-screen legacy renderer instead of being lazily converted and rendered as a (potentially multi-page) workflow. Gating on the paywall type fixes that while still skipping the endpoint entirely for true legacy v1 paywalls. Passing the workflow id (not the offering id) when mapped also fixes a silent prefetch cache-miss from the prior identifier mismatch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c2736c4 to
78142e1
Compare
2 tasks
facumenzella
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Jun 15, 2026
Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 tasks
facumenzella
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Jun 15, 2026
…low (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MonikaMateska
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Jun 16, 2026
* fix(paywalls): skip workflow fetch for offerings with no mapped workflow (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Rename PaywallComponentsData.state → stateDeclarations --------- Co-authored-by: Facundo Menzella <facumenzella@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MonikaMateska
pushed a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Jun 17, 2026
…low (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MonikaMateska
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Jun 17, 2026
* feat(RevenueCatUI): evaluate state conditions in the override resolver * fix(paywalls): skip workflow fetch for offerings with no mapped workflow (#7002) * fix(paywalls): skip workflow fetch for offerings with no mapped workflow Under workflows-enabled, presenting a paywall for an offering with only a legacy paywall (no workflow on the backend) fired a workflow fetch that 404'd and surfaced an error state instead of rendering the legacy paywall. Gate the workflow path on the offeringId -> workflowId map: no mapping renders the legacy paywall with no network call. Offerings are fetched first so the map is populated before the decision, avoiding a cold-cache downgrade of real workflow offerings. Port of RevenueCat/purchases-android#3598 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Gate legacy-vs-workflow on offering.paywall, not the workflows map Aligns with the merged purchases-android #3598: route an offering to the workflows endpoint only when `offering.paywall == nil` (the durable marker of a non-legacy paywall), instead of checking the offeringId -> workflowId map. The map check was an intermediate approach the Android PR abandoned: an offering not yet migrated to workflows is missing from the map, which would wrongly fall back to legacy for a real workflow offering. Reading offering.paywall is authoritative and removes the timing dependency on the map. Drops the cachedWorkflowId plumbing (no longer needed; Purchases.workflow already resolves the workflow id with an offering-id fallback) and the now-unused warning string. Applies the same gate to the synchronous cache seed for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(RevenueCatUI): broadcast paywall state snapshot via environment values * feat(RevenueCatUI): re-resolve component overrides from paywall state * feat(RevenueCatUI): publish Tabs selected state into the store * test(RevenueCatUI): add PaywallsTester sample for state-driven tabs * Use state declarations as decoding key * fix(paywalls): seed workflow state store with page declarations * Revert "fix(paywalls): seed workflow state store with page declarations" This reverts commit b555709. * fix(paywalls): stop stale state env from overriding workflow values * Use stateDeclarations wire key in state decoding tests * Revert Package.resolved to main --------- Co-authored-by: Facundo Menzella <facumenzella@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paywalls were served through the
/workflowsendpoint only when the offering was present in the prefetched offeringId→workflowId map. That map contains only paywalls converted to workflows, so a legacy v1 paywall errored on a 404 instead of renderingNote
Medium Risk
Changes core paywall presentation routing when workflows are enabled; wrong branching could break legacy paywalls or workflow fetches, but scope is limited to PaywallViewModel and covered by new tests.
Overview
Fixes paywall loading when workflows are enabled but an offering is still a legacy v1 paywall (or otherwise not in the prefetch offering→workflow map). Previously everything could be forced through
/workflows, which 404’d for legacy offerings.PaywallViewModel now branches on
offering.paywall == nullas the durable “non-legacy / workflow” signal: with workflows on, legacy offerings (paywallpresent) keep the existing legacy/components path and never call/workflows; non-legacy offerings fetch viapresentWorkflow, usingworkflowIdForOfferingIdwhen mapped (prefetch cache key) or offering id when not yet converted.The SDK exposes
Purchases.workflowIdForOfferingId(internal API) throughPurchasesTypefor RevenueCat UI, with mocks/tests updated to cover legacy skip, mapped workflow id, and offering-id fallback.Reviewed by Cursor Bugbot for commit 78142e1. Bugbot is set up for automated code reviews on this repo. Configure here.