Paywalls: improve template 5 landscape layout#3534
Merged
Conversation
13eb0ef to
f757c7f
Compare
tonidero
approved these changes
Dec 21, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just a question, but this should be good for now I think.
| .scrollableIfNecessary() | ||
| } | ||
|
|
||
| Spacer() |
Contributor
There was a problem hiding this comment.
Just curious but how does this look on an iPad in landscape? Just wondering whether the main content will be moved too much to the top, since I think we might want it centered within the available space?
Contributor
Author
There was a problem hiding this comment.
iPad landcape doesn't have "vertical height condensed", so this layout isn't used.
8eeaff7 to
dfb1314
Compare
I didn't notice this initially because I had been testing with 3 packages that happened to fill the screen
dfb1314 to
d5d6630
Compare
This was referenced Dec 21, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Dec 22, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: add header image to `watchOS` paywalls (#3542) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 5 landscape layout (#3534) via NachoSoto (@NachoSoto) * `Paywalls`: fix template 5 footer loading view alignment (#3537) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 1 landscape layout (#3532) via NachoSoto (@NachoSoto) * `Paywalls`: fix `ColorInformation.multiScheme` on `watchOS` (#3530) via NachoSoto (@NachoSoto) ### Other Changes * `Trusted Entitlements`: tests for signature verification without header hash (#3505) via NachoSoto (@NachoSoto) * `.debugRevenueCatOverlay`: added `Locale` (#3539) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: add support for signing request headers (#3424) via NachoSoto (@NachoSoto) * `CI`: Add architecture to cache keys (#3538) via Mark Villacampa (@MarkVillacampa) * `Paywalls Tester`: remove double close button (#3531) via NachoSoto (@NachoSoto) * Fix `RevenueCatUI` snapshot tests (#3526) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't notice this initially because I had been testing with 3 packages that happened to fill the screen
Before
After